allocator: add missing virtual destructor (#3)

add missing virtual destructor to base class and free gbm device on destruction of CGBMAllocator
hyprwm · Jul 6, 2024 · 263cb16 · 263cb16
1 parent 29c415a
commit 263cb16
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/include/aquamarine/allocator/Allocator.hpp b/include/aquamarine/allocator/Allocator.hpp
@@ -16,6 +16,7 @@ namespace Aquamarine {
 
     class IAllocator {
       public:
+        virtual ~IAllocator() = default;
         virtual Hyprutils::Memory::CSharedPointer<IBuffer>  acquire(const SAllocatorBufferParams& params, Hyprutils::Memory::CSharedPointer<CSwapchain> swapchain) = 0;
         virtual Hyprutils::Memory::CSharedPointer<CBackend> getBackend()                                                                                           = 0;
     };

diff --git a/include/aquamarine/allocator/GBM.hpp b/include/aquamarine/allocator/GBM.hpp
@@ -35,6 +35,7 @@ namespace Aquamarine {
 
     class CGBMAllocator : public IAllocator {
       public:
+        ~CGBMAllocator();
         static Hyprutils::Memory::CSharedPointer<CGBMAllocator> create(int drmfd_, Hyprutils::Memory::CWeakPointer<CBackend> backend_);
 
         virtual Hyprutils::Memory::CSharedPointer<IBuffer>      acquire(const SAllocatorBufferParams& params, Hyprutils::Memory::CSharedPointer<CSwapchain> swapchain_);

diff --git a/src/allocator/GBM.cpp b/src/allocator/GBM.cpp
@@ -183,6 +183,11 @@ SDMABUFAttrs Aquamarine::CGBMBuffer::dmabuf() {
     return attrs;
 }
 
+CGBMAllocator::~CGBMAllocator() {
+    if (gbmDevice)
+        gbm_device_destroy(gbmDevice);
+}
+
 SP<CGBMAllocator> Aquamarine::CGBMAllocator::create(int drmfd_, Hyprutils::Memory::CWeakPointer<CBackend> backend_) {
     uint64_t capabilities = 0;
     if (drmGetCap(drmfd_, DRM_CAP_PRIME, &capabilities) || !(capabilities & DRM_PRIME_CAP_EXPORT)) {