refactor: make consumer the only public interface for live event listener #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
============================================
+ Coverage 75.25% 75.40% +0.14%
Complexity 238 238
============================================
Files 43 44 +1
Lines 1063 1061 -2
Branches 88 88
============================================
Hits 800 800
+ Misses 228 226 -2
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 2 commits
December 27, 2023 13:28
| import org.apache.kafka.common.PartitionInfo; | ||
| import org.apache.kafka.common.TopicPartition; | ||
|
|
||
| public class KafkaMockConsumerTestUtil<K, V> { |
There was a problem hiding this comment.
Test utils can go in testFixtures so that production classes do not depend on them. Please refer to the following for a sample test fixture and its usage. https://github.com/Traceableai/activity-event-service/tree/main/policy-store-service-impl/src/testFixtures
There was a problem hiding this comment.
Thanks, didn't know about them. Updated to use testFixtures
kishansairam9
requested review from
suresh-prakash,
aaron-steinfeld and
laxmanchekka
laxmanchekka
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.