Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy curl command support in span detail component #2603

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

Greedy-Geek
Copy link
Contributor

No description provided.

@Greedy-Geek Greedy-Geek requested a review from a team as a code owner January 4, 2024 05:42
Copy link

github-actions bot commented Jan 4, 2024

Test Results

    4 files  ±0    317 suites  +1   32m 29s ⏱️ -24s
1 141 tests +5  1 137 ✅ +1  0 💤 ±0  4 ❌ +4 
1 151 runs  +5  1 147 ✅ +1  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 44208ff. ± Comparison against base commit 7080b66.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7080b66) 81.71% compared to head (79cebff) 81.74%.

❗ Current head 79cebff differs from pull request most recent head c96c779. Consider uploading reports for the commit c96c779 to get more accurate results

Files Patch % Lines
...ed/components/span-detail/span-detail.component.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
+ Coverage   81.71%   81.74%   +0.03%     
==========================================
  Files         928      929       +1     
  Lines       20794    20845      +51     
  Branches     3137     3145       +8     
==========================================
+ Hits        16991    17039      +48     
- Misses       3662     3665       +3     
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arjunlalb
arjunlalb previously approved these changes Jan 4, 2024
@@ -20,6 +21,7 @@ import { SpanRequestDetailModule } from './request/span-request-detail.module';
import { SpanResponseDetailModule } from './response/span-response-detail.module';
import { SpanDetailComponent } from './span-detail.component';
import { SpanTagsDetailModule } from './tags/span-tags-detail.module';
import { MemoizeModule } from '../../../../../common/src/utilities/memoize/memoize.module';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@Greedy-Geek Greedy-Geek requested a review from arjunlalb January 4, 2024 08:51
@Greedy-Geek Greedy-Geek enabled auto-merge (squash) January 4, 2024 08:53
@Greedy-Geek Greedy-Geek merged commit d9db405 into main Jan 4, 2024
10 checks passed
@Greedy-Geek Greedy-Geek deleted the copy-curl-command-support branch January 4, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants