chore: fixed the naming of entity cache #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kotharironak
commented
Feb 20, 2024
•
kotharironak
commented
- Prefixing the class name as part of entity cache
- Reference PR: https://github.com/hypertrace/hypertrace-ingester/pull/453/files
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
============================================
+ Coverage 79.58% 79.60% +0.02%
Complexity 1431 1431
============================================
Files 130 130
Lines 5697 5703 +6
Branches 533 533
============================================
+ Hits 4534 4540 +6
Misses 911 911
Partials 252 252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
kotharironak
requested review from
kishansairam9,
anujgoyal1,
laxmanchekka and
saxenakshitiz
This comment has been minimized.
This comment has been minimized.
saxenakshitiz
approved these changes
Feb 20, 2024
kotharironak
commented
Feb 20, 2024
| @@ -115,4 +115,13 @@ | |||
| <packageUrl regex="true">^pkg:maven/io\.grpc/grpc\-.*@.*$</packageUrl> | |||
| <cve>CVE-2023-44487</cve> | |||
| </suppress> | |||
| <suppress until="2024-03-30Z"> | |||
| <notes><
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.