update gradle to 8.5 #446
update gradle to 8.5 #446
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=========================================
Coverage 79.52% 79.52%
Complexity 1414 1414
=========================================
Files 127 127
Lines 5577 5577
Branches 516 516
=========================================
Hits 4435 4435
Misses 905 905
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kishansairam9
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
We don't need it here right now. |
kishansairam9
changed the title
This comment has been minimized.
This comment has been minimized.
build.gradle.kts
Outdated
| @@ -21,9 +21,6 @@ subprojects { | |||
|
|
|||
| pluginManager.withPlugin("java") { | |||
| configure<JavaPluginExtension> { | |||
| sourceCompatibility = JavaVersion.VERSION_11 | |||
There was a problem hiding this comment.
You can leave this as-is.
There was a problem hiding this comment.
Is it a problem if I remove it though? Do we default to java 11 in CI
There was a problem hiding this comment.
If removed it just means it defaults to the JVM of the environment it runs in. This should always have been specified in some way (toolchain, in modern gradle) but is missing in a lot of projects. The default in CI is java 11, yes. But we don't want to rely on that assumption for every developer's machine. In other words, this allows a user to run this build with a later jdk without issue.
This comment has been minimized.
This comment has been minimized.
No description provided.