Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert raw-span-constants to Java constants and make it private to span-normalizer only #71

Open
findingrish opened this issue Nov 26, 2020 · 4 comments
Open

Convert raw-span-constants to Java constants and make it private to span-normalizer only #71

findingrish opened this issue Nov 26, 2020 · 4 comments
Labels
enhancement New feature or request refactor

Comments

@findingrish
Copy link
Contributor

The entire platform consumes raw-constants. Can we do this?
@findingrish findingrish mentioned this issue Nov 26, 2020
Closed
@kotharironak
Copy link
Contributor

@rish691 Can you describe a problem in detail?

@findingrish
Copy link
Contributor Author

findingrish commented Dec 2, 2020 •
edited
Loading

This was a proposal originally made by @buchi-busireddy.
I am assuming the intention is to stop the usage of raw-span-constants in the platform and limit to the ingestion path.

@buchi-busireddy
Copy link
Contributor

This was a proposal originally made by @buchi-busireddy.
I am assuming the intention is to stop the usage of raw-span-constants in the platform and limit to the ingestion path.

Correct. The new library that we have written should be used everywhere and these constants could become private to that library then.

@findingrish findingrish added the enhancement New feature or request label Jan 8, 2021
@findingrish findingrish mentioned this issue Jan 29, 2021
Merged
@kotharironak
Copy link
Contributor

@rish691 is it done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@findingrish @buchi-busireddy @kotharironak