change punctuation, disable default rocksdb override (#429)

hypertrace · Oct 6, 2023 · 8e6c9f2 · 8e6c9f2
1 parent c96aaad
commit 8e6c9f2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/raw-spans-grouper/helm/values.yaml b/raw-spans-grouper/helm/values.yaml
@@ -109,7 +109,7 @@ rawSpansGrouperConfig:
     producerBufferMemory: 134217728 # default = 33554432
     # Consumer configs
     consumerMaxPartitionFetchBytes: 8388608 # default = 1048576
-    consumerMaxPollRecords: 1000 # default = 1000 (kafka streams default)
+    consumerMaxPollRecords: 10000 # default = 1000 (kafka streams default)
     consumerSessionTimeoutMs: 300000 # default = 10000
     # Changelog topic configs
     replicationFactor: 3

diff --git a/...aw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java b/...aw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java
@@ -225,9 +225,7 @@ private void schedulePunctuator(TraceIdentity key) {
             dataflowSamplingPercent);
     Cancellable cancellable =
         context.schedule(
-            Duration.ofMillis(groupingWindowTimeoutMs),
-            PunctuationType.WALL_CLOCK_TIME,
-            punctuator);
+            Duration.ofMillis(groupingWindowTimeoutMs), PunctuationType.STREAM_TIME, punctuator);
     punctuator.setCancellable(cancellable);
     logger.debug(
         "Scheduled a punctuator to emit trace for key=[{}] to run after [{}] ms",

diff --git a/raw-spans-grouper/raw-spans-grouper/src/main/resources/configs/common/application.conf b/raw-spans-grouper/raw-spans-grouper/src/main/resources/configs/common/application.conf
@@ -29,7 +29,6 @@ kafka.streams.config = {
   schema.registry.url = "http://localhost:8081"
   schema.registry.url = ${?SCHEMA_REGISTRY_URL}
 
-  rocksdb.config.setter = org.hypertrace.core.kafkastreams.framework.rocksdb.RocksDBStateStoreConfigSetter
   rocksdb.block.cache.size = 33554432
   rocksdb.write.buffer.size = 8388608
   rocksdb.max.write.buffers = 2