Skip to content

Commit

Permalink
Drop explicit support for python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
ericpre committed Jan 14, 2025
1 parent 00b0e83 commit 9de91c8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
run_test_site:
name: ${{ matrix.os }}-${{ matrix.PACKAGE_MANAGER }}-py${{ matrix.PYTHON_VERSION }}${{ matrix.LABEL }}
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os }}-latest
timeout-minutes: 30
env:
PIP_ARGS: '-e .'
Expand All @@ -25,29 +25,29 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest", "macos-13", "macos-latest", "windows-latest"]
PYTHON_VERSION: ['3.8', '3.10', '3.12']
os: ["ubuntu", "macos", "windows"]
PYTHON_VERSION: ['3.9', '3.10', '3.12']
PACKAGE_MANAGER: [conda, pip]
# Use only in conda based distribution
ENVIRONMENT_NAME: ["test_env"]
TEST_DEPS: ["qtconsole jupyterlab pytest"]
include:
# The python version of the base environment will be what comes with
# the distribution
- os: ubuntu-latest
- os: ubuntu
ENVIRONMENT_NAME: ''
PACKAGE_MANAGER: conda
TEST_DEPS: 'qtconsole jupyterlab pytest'
LABEL: _base_env
- os: ubuntu-latest
- os: ubuntu
PYTHON_VERSION: '3.13-dev'
PACKAGE_MANAGER: pip
TEST_DEPS: 'qtconsole pytest'
exclude:
# pip on macos doesn't seemt to play well with bash -l {0}, which is
# required to use setup-miniconda
- os: macos
PACKAGE_MANAGER: pip
- os: ubuntu
ENVIRONMENT_NAME: 'test_env'
PYTHON_VERSION: '3.11'
PACKAGE_MANAGER: conda
TEST_DEPS: 'qtconsole jupyterlab pytest'

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
url="https://github.com/hyperspy/start_jupyter_cm",
classifiers=[
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down

0 comments on commit 9de91c8

Please sign in to comment.