Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use errors.New to replace fmt.Errorf with no parameters #1277

Merged
merged 3 commits into from
Dec 10, 2024
Merged

chore: use errors.New to replace fmt.Errorf with no parameters #1277

merged 3 commits into from
Dec 10, 2024

Conversation

ChengenH
Copy link
Contributor

@ChengenH ChengenH commented Dec 10, 2024 •
edited
Loading

  1. remove repetitive words
  2. use errors.New to replace fmt.Errorf with no parameters

@ChengenH
docs: remove repetitive words
a240050 
Signed-off-by: ChengenH <hce19970702@gmail.com>
@ChengenH ChengenH requested a review from a team as a code owner December 10, 2024 09:40
@ChengenH
chore: use errors.New to replace fmt.Errorf with no parameters
9ec84d1 
Signed-off-by: ChengenH <hce19970702@gmail.com>
@ChengenH ChengenH changed the title docs: remove repetitive words chore: use errors.New to replace fmt.Errorf with no parameters Dec 10, 2024
bestbeforetoday
bestbeforetoday reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a minor indentation issue, looks good to me.

auction-dutch/chaincode-go/smart-contract/auction.go Outdated
Comment on lines 11 to 12
"errors"
"fmt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation looks to be spaces rather than tabs, as used by gofmt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have fixed it

@ChengenH
chore: Fixed some tab usage errors
80e8727 
Signed-off-by: ChengenH <hce19970702@gmail.com>
bestbeforetoday
bestbeforetoday approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@bestbeforetoday bestbeforetoday merged commit b71a458 into hyperledger:main Dec 10, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestbeforetoday bestbeforetoday bestbeforetoday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChengenH @bestbeforetoday