Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional miner methods #1604

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Add additional miner methods #1604

merged 7 commits into from
Jun 6, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Jun 3, 2024

Fixes #1592

Add miner methods:

  • miner_getExtraData request has no parameters, and the response is the hex string of the extra data bytes

  • miner_setExtraData request has only 1 parameter: the hex string of the extra data bytes.

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 4:50am

@joaniefromtheblock joaniefromtheblock changed the title Initial commit for additional miner methods Add additional miner methods Jun 3, 2024
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review June 3, 2024 20:19
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner June 3, 2024 20:19
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
macfarla added 2 commits June 5, 2024 12:04
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock merged commit 360aeee into main Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document miner_setExtraData and miner_getExtraData
3 participants