Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rlp decode subcommand #1593

Merged
merged 5 commits into from
May 17, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented May 14, 2024

Document the besu rlp decode subcommand for decoding IBFT 2.0 and QBFT RLP-encoded extraData strings. Minor fixes to related content for consistency. Fixes #1575.

Preview: https://besu-docs-5cuvz4xt6-hyperledger.vercel.app/development/private-networks/reference/cli/subcommands#decode

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
@alexandratran alexandratran requested a review from macfarla May 14, 2024 22:35
@alexandratran alexandratran requested a review from a team as a code owner May 14, 2024 22:35
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:52pm

Alexandra Tran added 2 commits May 14, 2024 15:35
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to and from are also optional - think we should explicitly say default is to use standard in / standard out - as shown in the examples already

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 3c087fe into hyperledger:main May 17, 2024
9 checks passed
@alexandratran alexandratran deleted the 1575-decode-subcommand branch May 17, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the decode subcommand
3 participants