updating logic -- api edits for only manager - error correction

Signed-off-by: Prakash P S <prakashps@Prakashs-MacBook-Pro.local>

packages/athena/libs/permissions_lib.js

@@ -224,16 +224,28 @@ module.exports = function (logger, ev, t) {
 					if (!email) {
 						input_errors.push('uuid does not exist: ' + encodeURI(uuid));
 					} else {
-						let admin_count = 0;
-						for (let user in settings_doc.access_list) {
-							if (user.roles.includes('manager'))
+						if (settings_doc.access_list[email].roles.includes('manager') && !lc_roles.includes('manager'))
+						{
+							let admin_count = 0;
+							for (let user in settings_doc.access_list) {
+								if (user.roles.includes('manager'))
+								{
+									admin_count = admin_count + 1;
+								}
+							}
+							if (admin_count < 2)
 							{
-								admin_count = admin_count + 1;
+								input_errors.push('[only manager] as you are the only manager for this console, you are not allowed to modify your roles');
+							}
+							else {
+								settings_doc.access_list[email].roles = lc_roles; 			// edit the user object
+
+								// build a notification doc
+								const notice = {
+									message: 'editing roles for user ' + t.misc.censorEmail(email) + ' - setting ' + lc_roles.join(', '),
+								};
+								t.notifications.procrastinate(req, notice);
 							}
-						}
-						if (settings_doc.access_list[email].roles.includes('manager') && admin_count < 2)
-						{
-							input_errors.push('[only manager] as you are the only manager for this console, you are not allowed to modify your roles');
 						}
 						else
 						{