fix: GHSA-8qv2-5vq6-g2g7 webpki CPU denial of service in certificate path #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
outSH
approved these changes
Dec 6, 2023
|
@petermetz build for relay is failing. Can we hold the PR merge, I'll try to fix this in this PR itself. |
sandeepnRES
force-pushed
the
fix-ghsa8qv25vq6g2g7_webpki_cpu_denial_of_service_in_certificate_path
branch
2 times, most recently
from
e36e5ba to
d989691
Compare
sandeepnRES
force-pushed
the
fix-ghsa8qv25vq6g2g7_webpki_cpu_denial_of_service_in_certificate_path
branch
from
d989691 to
b50bd82
Compare
|
This PR/issue depends on: |
…path 1. Upgraded tonic, prost and tokio to the latest and greatest of versions which was necessary because one of their transitive dependencies being affected by the GHSA-8qv2-5vq6-g2g7 vulnerability. 2. These upgrades also forced our hand in terms of bumping up the rust edition from 2018 to 2021 and upgrading the rust compiler to v1.74. 3. fix(relay): update the code for tonic 0.10.2 4. fix(relay): upgrade rust docker image tag to 1.69.0 Depends on hyperledger-cacti#2916 (which upgrades the rust compiler in the dev container) Co-authored by: Sandeep Nishad <sandeep.nishad1@ibm.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
sandeepnRES
force-pushed
the
fix-ghsa8qv25vq6g2g7_webpki_cpu_denial_of_service_in_certificate_path
branch
from
b50bd82 to
ed5267e
Compare
sandeepnRES
approved these changes
Dec 19, 2023
petermetz
deleted the
fix-ghsa8qv25vq6g2g7_webpki_cpu_denial_of_service_in_certificate_path
branch
@sandeepnRES Yes, of course, sorry for the slow response! I know it doesn't matter now that it's all been resolved ,but wanted to make sure I say it that it would've been totally fine to hold it because of a dependency like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which was necessary because one of their transitive dependencies being
affected by the GHSA-8qv2-5vq6-g2g7 vulnerability.
rust edition from 2018 to 2021 and upgrading the rust compiler to v1.74.
Depends on #2916 (which upgrades
the rust compiler in the dev container)
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.