Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Metrics #495

Merged
merged 45 commits into from
May 27, 2022
Merged

More Metrics #495

merged 45 commits into from
May 27, 2022

Conversation

mattiekat
Copy link
Contributor

@mattiekat mattiekat commented May 24, 2022 •
edited
Loading

  • Creates the ethers-prometheus crate which provides an Ethers Middlewear which exports metrics via prometheus.
  • Extended metrics in abacus-base to connect up with the new provider metrics
  • Updated abacus-ethereum to use the metrics middlewear if the metrics configuration is provided
  • Setup other metrics that were previously unused from abacus-base
  • Updated configs for local testing

Relates to #421

mattiekat added 21 commits May 12, 2022 12:57
@mattiekat
metrics refactoring
fdbb57e
@mattiekat
metrics refactoring
c2d0fa0
@mattiekat
Make brain hurt less by using a damn function
b19c40b
@mattiekat
patch through metrics to abacus_ethereum inbox and outbox
2464b3b
@mattiekat
WIP
3a94c67
@mattiekat
Minor cleanup
d31ecc4
@mattiekat
Merge branch 'main' into mattie/metrics
589091c
@mattiekat
work on time update
fb1f907
@mattiekat
added label arrays
156cf98
@mattiekat
refactoring
31730e9
@mattiekat
Metrics for sending txns
866f20e
@mattiekat
Metrics middleware
7b8e545
@mattiekat
cleanup
af0e2e9
@mattiekat
Merge branch 'main' into mattie/metrics
24144cf 
# Conflicts:
#	rust/abacus-base/src/settings/mod.rs
#	rust/chains/abacus-ethereum/src/inbox.rs
#	rust/chains/abacus-ethereum/src/lib.rs
#	rust/chains/abacus-ethereum/src/macros.rs
#	rust/chains/abacus-ethereum/src/outbox.rs
#	rust/chains/abacus-ethereum/src/validator_manager.rs
@mattiekat
Cleanup after merge
e2376d3
@mattiekat
Add metrics config and setup prom metrics with core metrics
d8b02c8
@mattiekat
Minor fixes to docs
5ed42b5
@mattiekat
Better trait building
81afd32
@mattiekat
rename
8394727
@mattiekat
Weave metrics through code
83b8488
@mattiekat
Use core metrics instead
36845d1
@mattiekat mattiekat changed the title Mattie/metrics More Metrics May 24, 2022
@mattiekat mattiekat marked this pull request as ready for review May 26, 2022 17:08
tkporter
tkporter approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! some beautiful rust code

rust/abacus-base/src/metrics/core.rs Show resolved Hide resolved
rust/ethers-prometheus/src/erc20.rs Outdated Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Outdated Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Outdated Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Outdated Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Show resolved Hide resolved
rust/ethers-prometheus/src/lib.rs Show resolved Hide resolved
@mattiekat mattiekat merged commit d687d3e into main May 27, 2022
@mattiekat mattiekat deleted the mattie/metrics branch May 27, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkporter tkporter tkporter approved these changes

@webbhorn webbhorn webbhorn approved these changes

@nambrot nambrot Awaiting requested review from nambrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattiekat @webbhorn @tkporter