import esm module from parseTree #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
approved these changes
Mar 11, 2024
jdesrosiers
added a commit
that referenced
this pull request
Mar 12, 2024
|
Unfortunately, I had to revert this. Although this fixes the vscode setup, it breaks the neovim setup. We need a solution that works for both. |
|
I managed to stumble on the right solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve the issue of using a temporary hack to run the language server as we are unable to use the bundled output due to a
MODULE NOT FOUNDerror.Description:
The
jsonc-parserdependency has two module implementations in its library, ESM and UMD. Now, VSCode requires us to bundle the code into a single CommonJS module but the thing isesbuilddoesn't have a built-in feature for direct UMD to CJS conversion but it does have ESM to CJS. Currently, the import uses the default export of the library which seems to be the UMD module, the solution is to simply change the import to the ESM module instead.