fix: run neowofetch directly on unix
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script should contain a shebang, so no need to spawn a subshell for it
hykilpikonna
approved these changes
Oct 25, 2024
|
Thanks! It works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
neowofetchshould contain a shebang and be directly executable, so we shouldn't be spawning a subshell for itRelevant Links
n/a
Screenshots
n/a
Additional context
This avoids
bashbeing a hard dependency in the user's$PATHwhen using the neofetch backend. It also helps in packaging hyfetch for Nix, Guix, etc. where binaries have their$PATHs explicitly wrapped with external binaries that are called