Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neofetch): list all Intel GPUs as detected #348

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented Sep 3, 2024

Now that Intel is selling its own dedicated GPUs, it is increasingly common to see laptops and desktop devices with multiple Intel GPUs. This patch is intended to fix GPU detection on a laptop with both an integrated UHD Graphics GPU and an Arc 380 (DG2).

Note that this may potentially cause regressions, but the original upstream did not record the original issue, so I'm inclined to write it off as an outdated fix:

  commit ee815f9c6651423ae93f8ead237ebc99e2373c06
  Author: Dylan Araps <dylan.araps@gmail.com>
  Date:   Mon Apr 9 09:51:23 2018 +1000

      gpu: Fixed duplicate intel bug.

Description

Describe the goals that the pull request accomplishes.

Relevant Links

If there are related issues, please link them here.

Please also include links relevant to the changes.

e.g. For new distros, include a link to the distro's official website, download link, or development repository.

Screenshots

If applicable, please include screenshots before and after your changes.

Additional context

Add any other context about the problem or changes here.

@MingcongBai
Copy link
Contributor Author

MingcongBai commented Sep 3, 2024

The offending lspci -mm output is attached below:

00:00.0 "Host bridge" "Intel Corporation" "11th Gen Core Processor Host Bridge/DRAM Registers" -r05 -p00 "Intel Corporation" "11th Gen Core Processor Host Bridge/DRAM Registers"
00:01.0 "PCI bridge" "Intel Corporation" "11th Gen Core Processor PCIe Controller #1" -r05 -p00 "Intel Corporation" "11th Gen Core Processor PCIe Controller"
00:02.0 "VGA compatible controller" "Intel Corporation" "Tiger Lake-H GT1 [UHD Graphics]" -r01 -p00 "Intel Corporation" "Tiger Lake-H GT1 [UHD Graphics]"
00:06.0 "PCI bridge" "Intel Corporation" "11th Gen Core Processor PCIe Controller #0" -r05 -p00 "Intel Corporation" "11th Gen Core Processor PCIe Controller"
00:0d.0 "USB controller" "Intel Corporation" "Tiger Lake-H Thunderbolt 4 USB Controller" -r05 -p30 "Intel Corporation" "Tiger Lake-H Thunderbolt 4 USB Controller"
00:14.0 "USB controller" "Intel Corporation" "Tiger Lake-H USB 3.2 Gen 2x1 xHCI Host Controller" -r11 -p30 "Intel Corporation" "Tiger Lake-H USB 3.2 Gen 2x1 xHCI Host Controller"
00:14.2 "RAM memory" "Intel Corporation" "Tiger Lake-H Shared SRAM" -r11 -p00 "Intel Corporation" "Tiger Lake-H Shared SRAM"
00:15.0 "Serial bus controller" "Intel Corporation" "Tiger Lake-H Serial IO I2C Controller #0" -r11 -p00 "Intel Corporation" "Tiger Lake-H Serial IO I2C Controller"
00:15.1 "Serial bus controller" "Intel Corporation" "Tiger Lake-H Serial IO I2C Controller #1" -r11 -p00 "Intel Corporation" "Tiger Lake-H Serial IO I2C Controller"
00:15.2 "Serial bus controller" "Intel Corporation" "Device 43ea" -r11 -p00 "Intel Corporation" "Device 7270"
00:15.3 "Serial bus controller" "Intel Corporation" "Device 43eb" -r11 -p00 "Intel Corporation" "Device 7270"
00:16.0 "Communication controller" "Intel Corporation" "Tiger Lake-H Management Engine Interface" -r11 -p00 "Intel Corporation" "Tiger Lake-H Management Engine Interface"
00:17.0 "SATA controller" "Intel Corporation" "Tiger Lake SATA AHCI Controller" -r11 -p01 "Intel Corporation" "Tiger Lake SATA AHCI Controller"
00:19.0 "Serial bus controller" "Intel Corporation" "Device 43ad" -r11 -p00 "Intel Corporation" "Device 7270"
00:19.1 "Serial bus controller" "Intel Corporation" "Device 43ae" -r11 -p00 "Intel Corporation" "Device 7270"
00:1d.0 "PCI bridge" "Intel Corporation" "Tiger Lake-H PCI Express Root Port #9" -r11 -p00 "Intel Corporation" "Tiger Lake-H PCI Express Root Port"
00:1d.2 "PCI bridge" "Intel Corporation" "Device 43b2" -r11 -p00 "Intel Corporation" "Device 7270"
00:1e.0 "Communication controller" "Intel Corporation" "Device 43a8" -r11 -p00 "Intel Corporation" "Device 7270"
00:1e.3 "Serial bus controller" "Intel Corporation" "Device 43ab" -r11 -p00 "Intel Corporation" "Device 7270"
00:1f.0 "ISA bridge" "Intel Corporation" "WM590 LPC/eSPI Controller" -r11 -p00 "Intel Corporation" "WM590 LPC/eSPI Controller"
00:1f.3 "Audio device" "Intel Corporation" "Tiger Lake-H HD Audio Controller" -r11 -p00 "Realtek Semiconductor Co., Ltd." "Tiger Lake-H HD Audio Controller"
00:1f.4 "SMBus" "Intel Corporation" "Tiger Lake-H SMBus Controller" -r11 -p00 "Intel Corporation" "Tiger Lake-H SMBus Controller"
00:1f.5 "Serial bus controller" "Intel Corporation" "Tiger Lake-H SPI Controller" -r11 -p00 "Intel Corporation" "Tiger Lake-H SPI Controller"
01:00.0 "PCI bridge" "Intel Corporation" "Device 4fa1" -r01 -p00 "" ""
02:01.0 "PCI bridge" "Intel Corporation" "Device 4fa4" -p00 "Intel Corporation" "Device 4fa4"
02:04.0 "PCI bridge" "Intel Corporation" "Device 4fa4" -p00 "Intel Corporation" "Device 0000"
03:00.0 "VGA compatible controller" "Intel Corporation" "DG2 [Arc A380]" -r05 -p00 "Shenzhen Gunnir Technology Development Co., Ltd" "DG2 [Arc A380]"
04:00.0 "Audio device" "Intel Corporation" "DG2 Audio Controller" -p00 "Shenzhen Gunnir Technology Development Co., Ltd" "DG2 Audio Controller"
05:00.0 "Non-Volatile memory controller" "Realtek Semiconductor Co., Ltd." "RTS5772DL NVMe SSD Controller (DRAM-less)" -r01 -p02 "Realtek Semiconductor Co., Ltd." "RTS5772DL NVMe SSD Controller (DRAM-less)"
06:00.0 "Network controller" "Qualcomm Technologies, Inc" "QCNFA765 Wireless Network Adapter" -r01 -p00 "Foxconn International, Inc." "QCNFA765 Wireless Network Adapter"
07:00.0 "Ethernet controller" "Realtek Semiconductor Co., Ltd." "RTL8111/8168/8211/8411 PCI Express Gigabit Ethernet Controller" -r15 -p00 "Realtek Semiconductor Co., Ltd." "RTL8111/8168/8211/8411 PCI Express Gigabit Ethernet Controller"

Now that Intel is selling its own dedicated GPUs, it is increasingly
common to see laptops and desktop devices with multiple Intel GPUs. This
patch is intended to fix GPU detection on a laptop with both an integrated
UHD Graphics GPU and an Arc 380 (DG2).

Note that this may potentially cause regressions, but the original
upstream did not record the original issue, so I'm inclined to write it
off as an outdated fix:

  commit ee815f9
  Author: Dylan Araps <dylan.araps@gmail.com>
  Date:   Mon Apr 9 09:51:23 2018 +1000

      gpu: Fixed duplicate intel bug.
@MingcongBai MingcongBai force-pushed the bai/fix-intel-multi-gpu branch from e957a99 to 3866ad0 Compare September 3, 2024 08:57
@CarterLi
Copy link
Contributor

CarterLi commented Sep 3, 2024

Finally found a dedicated Intel GPU user. May I have some information about the dedicated Arc GPU?

  • ls -l /sys/class/drm/card?

  • ls -l /sys/class/drm/card?/device

@MingcongBai
Copy link
Contributor Author

Finally found a dedicated Intel GPU user. May I have some information about the dedicated Arc GPU?

* ls -l /sys/class/drm/card?

* ls -l /sys/class/drm/card?/device

Hi, this is from a user, I have requested that he supply the outputs. Here they are:

powervr@Aosc-Xoen [ ~ ] $ ls -l /sys/class/drm/card?
lrwxrwxrwx 1 root root 0  9月 3日 20:28 /sys/class/drm/card0 -> ../../devices/pci0000:00/0000:00:02.0/drm/card0
lrwxrwxrwx 1 root root 0  9月 3日 20:28 /sys/class/drm/card1 -> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/0000:02:01.0/0000:03:00.0/drm/card1

powervr@Aosc-Xoen [ ~ ] $ ls -l /sys/class/drm/card?/device
lrwxrwxrwx 1 root root 0  9月 3日 20:28 /sys/class/drm/card0/device -> ../../../0000:00:02.0
lrwxrwxrwx 1 root root 0  9月 3日 20:28 /sys/class/drm/card1/device -> ../../../0000:03:00.0

@CarterLi
Copy link
Contributor

CarterLi commented Sep 3, 2024

Well yeah, I think I meant

  • ls -l /sys/class/drm/card?/
  • ls -l /sys/class/drm/card?/device/

@MingcongBai
Copy link
Contributor Author

  • ls -l /sys/class/drm/card?/

  • ls -l /sys/class/drm/card?/device/

powervr@Aosc-Xoen [ ~ ] $  ls -l /sys/class/drm/card?/
/sys/class/drm/card0/:
总计 0
drwxr-xr-x  5 root root    0  9月 3日 20:28 card0-DP-1
drwxr-xr-x  3 root root    0  9月 3日 20:28 card0-HDMI-A-1
drwxr-xr-x  3 root root    0  9月 3日 20:28 card0-HDMI-A-2
-r--r--r--  1 root root 4096  9月 3日 22:56 dev
lrwxrwxrwx  1 root root    0  9月 3日 20:28 device -> ../../../0000:00:02.0
drwxr-xr-x  7 root root    0  9月 3日 20:34 engine
-rw-------  1 root root    0  9月 3日 22:56 error
drwxr-xr-x  3 root root    0  9月 3日 20:34 gt
-r--r--r--  1 root root 4096  9月 3日 22:56 gt_act_freq_mhz
-rw-r--r--  1 root root 4096  9月 3日 22:56 gt_boost_freq_mhz
-r--r--r--  1 root root 4096  9月 3日 22:56 gt_cur_freq_mhz
-rw-r--r--  1 root root 4096  9月 3日 20:28 gt_max_freq_mhz
-rw-r--r--  1 root root 4096  9月 3日 20:28 gt_min_freq_mhz
-r--r--r--  1 root root 4096  9月 3日 22:56 gt_RP0_freq_mhz
-r--r--r--  1 root root 4096  9月 3日 22:56 gt_RP1_freq_mhz
-r--r--r--  1 root root 4096  9月 3日 22:56 gt_RPn_freq_mhz
drwxr-xr-x 25 root root    0  9月 3日 20:28 metrics
drwxr-xr-x  2 root root    0  9月 3日 20:34 power
lrwxrwxrwx  1 root root    0  9月 3日 20:28 subsystem -> ../../../../../class/drm
-rw-r--r--  1 root root 4096  9月 3日 20:28 uevent

/sys/class/drm/card1/:
总计 0
drwxr-xr-x   5 root root    0  9月 3日 20:28 card1-DP-2
drwxr-xr-x   5 root root    0  9月 3日 20:28 card1-DP-3
drwxr-xr-x   5 root root    0  9月 3日 20:28 card1-DP-4
drwxr-xr-x   3 root root    0  9月 3日 20:28 card1-HDMI-A-3
drwxr-xr-x   3 root root    0  9月 3日 20:28 card1-HDMI-A-4
drwxr-xr-x   3 root root    0  9月 3日 20:28 card1-HDMI-A-5
drwxr-xr-x   3 root root    0  9月 3日 20:28 card1-HDMI-A-6
-r--r--r--   1 root root 4096  9月 3日 22:56 dev
lrwxrwxrwx   1 root root    0  9月 3日 20:28 device -> ../../../0000:03:00.0
drwxr-xr-x   9 root root    0  9月 3日 20:34 engine
-rw-------   1 root root    0  9月 3日 22:56 error
drwxr-xr-x   3 root root    0  9月 3日 20:34 gt
-r--r--r--   1 root root 4096  9月 3日 22:56 gt_act_freq_mhz
-rw-r--r--   1 root root 4096  9月 3日 22:56 gt_boost_freq_mhz
-r--r--r--   1 root root 4096  9月 3日 22:56 gt_cur_freq_mhz
-rw-r--r--   1 root root 4096  9月 3日 20:28 gt_max_freq_mhz
-rw-r--r--   1 root root 4096  9月 3日 20:28 gt_min_freq_mhz
-r--r--r--   1 root root 4096  9月 3日 22:56 gt_RP0_freq_mhz
-r--r--r--   1 root root 4096  9月 3日 22:56 gt_RP1_freq_mhz
-r--r--r--   1 root root 4096  9月 3日 22:56 gt_RPn_freq_mhz
drwxr-xr-x 347 root root    0  9月 3日 20:28 metrics
drwxr-xr-x   2 root root    0  9月 3日 20:34 power
lrwxrwxrwx   1 root root    0  9月 3日 20:28 subsystem -> ../../../../../../../../class/drm
-rw-r--r--   1 root root 4096  9月 3日 20:28 uevent

@MingcongBai
Copy link
Contributor Author

 powervr@Aosc-Xoen [ ~ ] $ ls -l /sys/class/drm/card?/device/
/sys/class/drm/card0/device/:
总计 0
-r--r--r-- 1 root root      4096  9月 3日 22:57 ari_enabled
-r--r--r-- 1 root root      4096  9月 3日 20:28 boot_vga
-rw-r--r-- 1 root root      4096  9月 3日 22:57 broken_parity_status
-r--r--r-- 1 root root      4096  9月 3日 20:28 class
-rw-r--r-- 1 root root      4096  9月 3日 20:28 config
-r--r--r-- 1 root root      4096  9月 3日 22:57 consistent_dma_mask_bits
lrwxrwxrwx 1 root root         0  9月 3日 22:57 consumer:pci:0000:00:1f.3 -> ../../virtual/devlink/pci:0000:00:02.0--pci:0000:00:1f.3
-r--r--r-- 1 root root      4096  9月 3日 22:57 current_link_speed
-r--r--r-- 1 root root      4096  9月 3日 22:57 current_link_width
-rw-r--r-- 1 root root      4096  9月 3日 22:57 d3cold_allowed
-r--r--r-- 1 root root      4096  9月 3日 20:28 device
-r--r--r-- 1 root root      4096  9月 3日 22:57 devspec
-r--r--r-- 1 root root      4096  9月 3日 22:57 dma_mask_bits
lrwxrwxrwx 1 root root         0  9月 3日 20:28 driver -> ../../../bus/pci/drivers/i915
-rw-r--r-- 1 root root      4096  9月 3日 22:57 driver_override
drwxr-xr-x 4 root root         0  9月 3日 20:28 drm
-rw-r--r-- 1 root root      4096  9月 3日 22:57 enable
lrwxrwxrwx 1 root root         0  9月 3日 22:57 firmware_node -> ../../LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/LNXVIDEO:00
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-0
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-1
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-2
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-3
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-4
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-5
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-6
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-7
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-8
-r--r--r-- 1 root root      4096  9月 3日 22:57 index
lrwxrwxrwx 1 root root         0  9月 3日 22:57 iommu -> ../../virtual/iommu/dmar0
lrwxrwxrwx 1 root root         0  9月 3日 22:57 iommu_group -> ../../../kernel/iommu_groups/0
-r--r--r-- 1 root root      4096  9月 3日 20:35 irq
-r--r--r-- 1 root root      4096  9月 3日 22:57 label
drwxr-xr-x 2 root root         0  9月 3日 20:34 link
-r--r--r-- 1 root root      4096  9月 3日 22:57 local_cpulist
-r--r--r-- 1 root root      4096  9月 3日 22:57 local_cpus
-r--r--r-- 1 root root      4096  9月 3日 22:57 max_link_speed
-r--r--r-- 1 root root      4096  9月 3日 22:57 max_link_width
-r--r--r-- 1 root root      4096  9月 3日 22:57 modalias
-rw-r--r-- 1 root root      4096  9月 3日 22:57 msi_bus
drwxr-xr-x 2 root root         0  9月 3日 20:34 msi_irqs
-rw-r--r-- 1 root root      4096  9月 3日 22:57 numa_node
drwxr-xr-x 2 root root         0  9月 3日 20:34 power
-r--r--r-- 1 root root      4096  9月 3日 22:57 power_state
--w--w---- 1 root root      4096  9月 3日 22:57 remove
--w------- 1 root root      4096  9月 3日 22:57 rescan
--w------- 1 root root      4096  9月 3日 22:57 reset
-rw-r--r-- 1 root root      4096  9月 3日 22:57 reset_method
-r--r--r-- 1 root root      4096  9月 3日 20:28 resource
-rw------- 1 root root  16777216  9月 3日 22:57 resource0
-rw------- 1 root root 268435456  9月 3日 22:57 resource2
-rw------- 1 root root 268435456  9月 3日 22:57 resource2_wc
-rw------- 1 root root        64  9月 3日 22:57 resource4
-r--r--r-- 1 root root      4096  9月 3日 20:28 revision
-rw------- 1 root root    131072  9月 3日 22:57 rom
-rw-r--r-- 1 root root      4096  9月 3日 22:57 sriov_drivers_autoprobe
-rw-r--r-- 1 root root      4096  9月 3日 22:57 sriov_numvfs
-r--r--r-- 1 root root      4096  9月 3日 22:57 sriov_offset
-r--r--r-- 1 root root      4096  9月 3日 22:57 sriov_stride
-r--r--r-- 1 root root      4096  9月 3日 22:57 sriov_totalvfs
-r--r--r-- 1 root root      4096  9月 3日 22:57 sriov_vf_device
-r--r--r-- 1 root root      4096  9月 3日 22:57 sriov_vf_total_msix
lrwxrwxrwx 1 root root         0  9月 3日 20:28 subsystem -> ../../../bus/pci
-r--r--r-- 1 root root      4096  9月 3日 20:28 subsystem_device
-r--r--r-- 1 root root      4096  9月 3日 20:28 subsystem_vendor
lrwxrwxrwx 1 root root         0  9月 3日 22:57 supplier:mei:0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1 -> ../../virtual/devlink/mei:0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1--pci:0000:00:02.0
-rw-r--r-- 1 root root      4096  9月 3日 20:28 uevent
-r--r--r-- 1 root root      4096  9月 3日 20:28 vendor

/sys/class/drm/card1/device/:
总计 0
-r--r--r-- 1 root root      4096  9月 3日 22:57 ari_enabled
-r--r--r-- 1 root root      4096  9月 3日 20:28 boot_vga
-rw-r--r-- 1 root root      4096  9月 3日 22:57 broken_parity_status
-r--r--r-- 1 root root      4096  9月 3日 20:28 class
-rw-r--r-- 1 root root      4096  9月 3日 20:28 config
-r--r--r-- 1 root root      4096  9月 3日 22:57 consistent_dma_mask_bits
lrwxrwxrwx 1 root root         0  9月 3日 22:57 consumer:pci:0000:04:00.0 -> ../../../../../virtual/devlink/pci:0000:03:00.0--pci:0000:04:00.0
-r--r--r-- 1 root root      4096  9月 3日 22:57 current_link_speed
-r--r--r-- 1 root root      4096  9月 3日 22:57 current_link_width
-rw-r--r-- 1 root root      4096  9月 3日 22:57 d3cold_allowed
-r--r--r-- 1 root root      4096  9月 3日 20:28 device
-r--r--r-- 1 root root      4096  9月 3日 22:57 devspec
-r--r--r-- 1 root root      4096  9月 3日 22:57 dma_mask_bits
lrwxrwxrwx 1 root root         0  9月 3日 20:28 driver -> ../../../../../../bus/pci/drivers/i915
-rw-r--r-- 1 root root      4096  9月 3日 22:57 driver_override
drwxr-xr-x 4 root root         0  9月 3日 20:28 drm
-rw-r--r-- 1 root root      4096  9月 3日 22:57 enable
drwxr-xr-x 3 root root         0  9月 3日 20:28 graphics
drwxr-xr-x 3 root root         0  9月 3日 20:28 hwmon
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-10
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-11
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-12
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-13
drwxr-xr-x 4 root root         0  9月 3日 20:28 i2c-14
drwxr-xr-x 7 root root         0  9月 3日 20:28 i915.mei-gsc.768
drwxr-xr-x 9 root root         0  9月 3日 20:28 i915.mei-gscfi.768
lrwxrwxrwx 1 root root         0  9月 3日 22:57 iommu -> ../../../../../virtual/iommu/dmar1
lrwxrwxrwx 1 root root         0  9月 3日 22:57 iommu_group -> ../../../../../../kernel/iommu_groups/17
-r--r--r-- 1 root root      4096  9月 3日 20:35 irq
drwxr-xr-x 2 root root         0  9月 3日 20:34 link
-r--r--r-- 1 root root      4096  9月 3日 22:57 local_cpulist
-r--r--r-- 1 root root      4096  9月 3日 22:57 local_cpus
-r--r--r-- 1 root root      4096  9月 3日 22:57 max_link_speed
-r--r--r-- 1 root root      4096  9月 3日 22:57 max_link_width
-r--r--r-- 1 root root      4096  9月 3日 20:28 modalias
-rw-r--r-- 1 root root      4096  9月 3日 22:57 msi_bus
drwxr-xr-x 2 root root         0  9月 3日 20:34 msi_irqs
-rw-r--r-- 1 root root      4096  9月 3日 22:57 numa_node
drwxr-xr-x 2 root root         0  9月 3日 20:34 power
-r--r--r-- 1 root root      4096  9月 3日 22:57 power_state
--w--w---- 1 root root      4096  9月 3日 22:57 remove
--w------- 1 root root      4096  9月 3日 22:57 rescan
--w------- 1 root root      4096  9月 3日 22:57 reset
-rw-r--r-- 1 root root      4096  9月 3日 22:57 reset_method
-r--r--r-- 1 root root      4096  9月 3日 20:28 resource
-rw------- 1 root root  16777216  9月 3日 22:57 resource0
-rw------- 1 root root 268435456  9月 3日 22:57 resource2
-rw-r--r-- 1 root root      4096  9月 3日 22:57 resource2_resize
-rw------- 1 root root 268435456  9月 3日 22:57 resource2_wc
-r--r--r-- 1 root root      4096  9月 3日 20:28 revision
-rw------- 1 root root   2097152  9月 3日 22:57 rom
lrwxrwxrwx 1 root root         0  9月 3日 20:28 subsystem -> ../../../../../../bus/pci
-r--r--r-- 1 root root      4096  9月 3日 20:28 subsystem_device
-r--r--r-- 1 root root      4096  9月 3日 20:28 subsystem_vendor
-rw-r--r-- 1 root root      4096  9月 3日 20:28 uevent
-r--r--r-- 1 root root      4096  9月 3日 20:28 vendor

@CarterLi
Copy link
Contributor

CarterLi commented Sep 3, 2024

What does ls -l --tree /sys/class/drm/card1/device/hwmon/ print?

@MingcongBai
Copy link
Contributor Author

ls -l --tree /sys/class/drm/card1/device/hwmon/

Is this for validating this pull request or purely for your curiosity?

@CarterLi
Copy link
Contributor

CarterLi commented Sep 3, 2024

My curiosity only

@MingcongBai
Copy link
Contributor Author

My curiosity only

Then please consider contacting me directly and not flood this thread.

Copy link
Collaborator

@catumin catumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the desired result of no longer removing the dedicated Intel GPU.

image

@catumin catumin merged commit 9636c98 into hykilpikonna:master Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants