hydro_deploy v0.8.0

Refactor

• remove unneeded Arc<RwLock< wrapping of launch_binary return value (1/3)

  Curious if there was any intention behind why it was Arc<RwLock<?

  I think before some refactors we took the I/O handles instead of using broadcast channels.

• build cache cleanup

  • Replace mystery tuple with new struct BuildOutput
  • Replace Mutex and Arc-infested HashMap with memo-map crate,
    greatly simplifying build cache typing
  • Remove redundant build caching in HydroflowCrateService, expose and
    use cache parameters as BuildParams
  • Remove once_cell and async-once-cell dependencies, use std's
    OnceLock
  • Add Failed to execute command: {} context to perf error message
  • Cleanup some repeated format! expressions

Style

• rename SSH -> Ssh

Refactor (BREAKING)

• make Service::collect_resources take &self instead of &mut self
  #430 but still has RwLock wrapping

  Depends on #1347

• make Host trait use &self interior mutability to remove RwLock wrappings #430
  Depends on #1346

• Make Host::provision not async anymore
  I noticed that none of the method impls have any awaits

• make HydroflowSource, HydroflowSink traits use &self interior mutability to remove RwLock wrappings #430
  Depends on #1339

• replace async-channel with tokio::sync::mpsc::unbounded_channel
  Depends on #1339

  We could make the publicly facing stdout, stderr APIs return impl Stream<Output = String> in the future, maybe

• replace some uses of tokio::sync::RwLock with std::sync::Mutex #430 (3/3)

Style (BREAKING)

• enable clippy upper-case-acronyms-aggressive
  • rename GCP -> Gcp, NodeID -> NodeId
  • update CI cargo-generate template testing to use PR's branch instead
    of whatever main happens to be

Commit Statistics

• 10 commits contributed to the release over the course of 10 calendar days.
• 59 days passed between releases.
• 10 commits were understood as conventional.
• 10 unique issues were worked on: #1334, #1338, #1339, #1340, #1343, #1345, #1346, #1347, #1348, #1356

Commit Details

view details

• #1334
  • Build cache cleanup (0feae74)
• #1338
  • Remove unneeded Arc<RwLock< wrapping of launch_binary return value (1/3) (e3e6933)
• #1339
  • Replace some uses of tokio::sync::RwLock with std::sync::Mutex #430 (3/3) (141eae1)
• #1340
  • Rename SSH -> Ssh (947ebc1)
• #1343
  • Make Host::provision not async anymore (f536ecc)
• #1345
  • Enable clippy upper-case-acronyms-aggressive (12b8ba5)
• #1346
  • Make HydroflowSource, HydroflowSink traits use &self interior mutability to remove RwLock wrappings #430 (057a0a5)
• #1347
  • Make Host trait use &self interior mutability to remove RwLock wrappings #430 (c5a8de2)
• #1348
  • Make Service::collect_resources take &self instead of &mut self (2286558)
• #1356
  • Replace async-channel with tokio::sync::mpsc::unbounded_channel (6039078)