Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency jetbrains/phpstorm-stubs needs to be updated to v2024.3 for PHP 8.4 compatibility #1099

Closed
sebastianbergmann opened this issue Jan 2, 2025 · 2 comments

Comments

@sebastianbergmann
Copy link
Contributor

Quoting myself from #1092 (comment):

use PropertyHookType; in Generator.php is [...] transformed into use PHPUnitPHAR\PropertyHookType;.

The above seems to happen because PHP-Scoper 0.18.15 comes with version v2024.2 of the jetbrains/phpstorm-stubs which does not know about classes such as PropertyHookType that were introduced in PHP 8.4. The first version of jetbrains/phpstorm-stubs to support PHP 8.4 is v2024.3.

@sebastianbergmann
Copy link
Contributor Author

I have updated the dependency in #1100, built a PHAR of PHP-Scoper using make bin/php-scoper.phar, and then copied bin/php-scoper.phar to tools/php-scoper in my checkout of branch 11.5 of PHPUnit's Git repository. I then used ant phar-snapshot to build a PHAR for PHPUnit using the php-scoper PHAR that has version v2024.3 of jetbrains/phpstorm-stubs.

I can now confirm that PHP-Scoper does not transform use PropertyHookType; into use PHPUnitPHAR\PropertyHookType; when version v2024.3 of jetbrains/phpstorm-stubs is used.

@jankal
Copy link

jankal commented Jan 13, 2025

@theofidry / @sebastianbergmann can be closed because #1100 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants