Skip to content

Commit

Permalink
resource/alicloud_oss_bucket: Improved the filed resource_group_id.
Browse files Browse the repository at this point in the history
  • Loading branch information
huiguangjun authored and ChenHanZhang committed Jul 3, 2024
1 parent 6b1177b commit 21439f6
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
17 changes: 15 additions & 2 deletions alicloud/resource_alicloud_oss_bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,21 @@ func resourceAlicloudOssBucketCreate(d *schema.ResourceData, meta interface{}) e
oss.RedundancyType(oss.DataRedundancyType(d.Get("redundancy_type").(string))),
oss.ACL(oss.ACLType(d.Get("acl").(string))),
}
options := []oss.Option{
req.StorageClassOption,
req.RedundancyTypeOption,
req.AclTypeOption,
}

//resource_group_id
if resourceGroupId, ok := d.Get("resource_group_id").(string); ok {
if len(resourceGroupId) > 0 {
options = append(options, oss.SetHeader("x-oss-resource-group-id", resourceGroupId))
}
}

raw, err = client.WithOssClient(func(ossClient *oss.Client) (interface{}, error) {
return nil, ossClient.CreateBucket(req.BucketName, req.StorageClassOption, req.RedundancyTypeOption, req.AclTypeOption)
return nil, ossClient.CreateBucket(req.BucketName, options...)
})
if err != nil {
return WrapErrorf(err, DefaultErrorMsg, "alicloud_oss_bucket", "CreateBucket", AliyunOssGoSdk)
Expand Down Expand Up @@ -1043,7 +1056,7 @@ func resourceAlicloudOssBucketUpdate(d *schema.ResourceData, meta interface{}) e
d.SetPartial("transfer_acceleration")
}

if d.HasChange("resource_group_id") {
if !d.IsNewResource() && d.HasChange("resource_group_id") {
resourceGroupId := d.Get("resource_group_id").(string)
request := map[string]string{"bucketName": d.Id(), "resourceGroupId": resourceGroupId}
var requestInfo *oss.Client
Expand Down
3 changes: 3 additions & 0 deletions alicloud/resource_alicloud_oss_bucket_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2225,13 +2225,15 @@ func TestAccAliCloudOssBucketResourceGroup(t *testing.T) {
Config: testAccConfig(map[string]interface{}{
"bucket": name,
"resource_group_id": "${data.alicloud_resource_manager_resource_groups.default.groups.1.id}",
"redundancy_type": "LRS",
}),
Check: resource.ComposeTestCheckFunc(
testAccCheck(map[string]string{
"bucket": name,
"access_monitor.#": "1",
"access_monitor.0.status": "Disabled",
"resource_group_id": CHECKSET,
"redundancy_type": "LRS",
}),
),
},
Expand All @@ -2244,6 +2246,7 @@ func TestAccAliCloudOssBucketResourceGroup(t *testing.T) {
{
Config: testAccConfig(map[string]interface{}{
"resource_group_id": "${data.alicloud_resource_manager_resource_groups.default.groups.0.id}",
"force_destroy": true,
}),
Check: resource.ComposeTestCheckFunc(
testAccCheck(map[string]string{
Expand Down

0 comments on commit 21439f6

Please sign in to comment.