[Core] Enhancements and refactoring of LoRA method #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Refactor LoRA code 2. Add method to delete LoRA adapters 3. Add method to unload the PEFT LoRA model. 4. Add `svd` weighted adapter support. 5. minor fixes
…nctionality-updates
|
The documentation is not available anymore as the PR was closed or merged. |
…nctionality-updates
There was a problem hiding this comment.
Very nice addition. This should give users much better control about how they deal with the adapters. I like it a lot.
I left a few comments, please take a look. I would also like to see tests for the new functionality, but I would be okay with them being added in a later PR.
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
|
@pacman100 Nice additions, especially the tests. Some are still failing, could you please check? |
BenjaminBossan
approved these changes
Jul 14, 2023
younesbelkada
approved these changes
Jul 14, 2023
4 tasks
pacman100
deleted the
smangrul/lora-weighted-and-delete-adapter-functionality-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?