MNT Remove Python 3.8 since it's end of life #2135
Conversation
The end of life of Python 3.8 has arrived: https://devguide.python.org/versions/ Therefore, Python 3.8 is removed from CI. Many tests are already failing as a transformers import raises an error that looks like it's caused by missing Python 3.8 support: E RuntimeError: Failed to import transformers.models.auto because of the following error (look up to see its traceback): E 'type' object is not subscriptable By default, Python 3.11 is now used. Python 3.12 should be added to the CI matrix now, but that's for a separate PR.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
The workflow tried to build on top of docker/README.md because globbing was too broadly defined.
Reduce unnecessary steps to hopefully get disk space usage down, as GitHub action currently fails with not enough disk space.
| @@ -2722,10 +2722,8 @@ def test_hqq_lora_model_outputs(self): | |||
| assert cc_matrix.min() > 0.97 | |||
|
|
|||
|
|
|||
| # TODO: unskip the tests once https://github.com/casper-hansen/AutoAWQ/issues/466 is fixed | |||
There was a problem hiding this comment.
Not totally unrelated, I had to update the AutoAWQ wheels and the new wheels should contain the fix mentioned here.
|
Update: The transformers issue might be unintended and not caused by intentionally dropping support for Python 3.8, which is only planned for the end of the month (see internal discussion Edit: This should now be fixed on transformers, let's wait what CI says tomorrow. Regardless of that, since Python 3.8 will drop at the end of the month (Oct 2024), let's keep this PR open and merge then. |
|
Will propagate this into |
The end of life of Python 3.8 has arrived:
https://devguide.python.org/versions/
Therefore, Python 3.8 is removed from CI. Many tests are already failing as a transformers import raises an error that looks like it's caused by missing Python 3.8 support:
(example 1, example 2)
By default, Python 3.11 is now used.
Python 3.12 should be added to the CI matrix now, but that's for a separate PR.