FIX: A few issues with AdaLora, extending GPU tests #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a handful of issues with AdaLora, should resolve huggingface#1113. Description 1. lora_A.weight.device was called but for AdaLora, lora_A is a nn.Paramter, not an nn.Module, so the weight attribute does not exist. lora_A.device is sufficient. 2. For 8bit, an inplace operation failed because it was on a view. Now the operation is no longer inplace. 3. The loss term of the model output is not necessarily a torch tensor. In the test, it was a dict and did not contain an actual loss. Therefore, I added a check to make sure the loss is a torch tensor. Is there a better way? Notes Running pytest tests/test_gpu_examples.py -k adalora locally (with GPU) passes. Ideally, someone else can confirm, as normal unit tests won't catch this. If this is merged before huggingface#1115, skipping AdaLora tests in that PR can be removed.
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
Nov 17, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a handful of issues with AdaLora, should resolve #1113.
Description
lora_A.weight.devicewas called but for AdaLora,lora_Ais annn.Paramter, not annn.Module, so the weight attribute does not exist.lora_A.deviceis sufficient.Notes
Running
pytest tests/test_gpu_examples.py -k adaloralocally (with GPU) passes. Ideally, someone else can confirm, as normal unit tests won't catch this.If this is merged before #1115, skipping AdaLora tests in that PR can be removed.