-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes warning when initializing prompt encoder (#716)
Right now, when the user initializes a prompt encoder with MLP, they get a warning that a certain argument is ignored, and there is no possible value for the argument that would stop the warning. Usually, warnings are for issues that something is (probably) going wrong, but here, everything is going as expected. Therefore, by default, I would not give this warning, thus avoiding users getting confused. However, I would still give the warning if the user set the argument for encoder_num_layers explicitly to a different value. In that case, they expect the change to make a difference, but since the argument is ignored, their expectation is not met, which warrants a warning.
- Loading branch information
1 parent
1681ceb
commit e06d94d
Showing
2 changed files
with
32 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters