Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify model id for test #1628

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Modify model id for test #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3cbc3
Modify model id for test
echarlaix Jan 8, 2024
333c4ad
add comment
echarlaix Jan 8, 2024
81e7871
update comment
echarlaix Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/onnxruntime/test_modeling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,7 @@ class ORTModelForQuestionAnsweringIntegrationTest(ORTModelTestMixin):
"roberta",
"roformer",
"squeezebert",
"xlm",
"xlm_qa",
"xlm_roberta",
]

Expand Down
1 change: 1 addition & 0 deletions tests/onnxruntime/utils_onnxruntime_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@
"wav2vec2-conformer": "hf-internal-testing/tiny-random-wav2vec2-conformer",
"wavlm": "hf-internal-testing/tiny-random-WavlmModel",
"xlm": "hf-internal-testing/tiny-random-XLMModel",
"xlm_qa": "hf-internal-testing/tiny-random-XLMForQuestionAnsweringSimple", # issue with default hf-internal-testing in transformers QA pipeline post-processing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, hf-internal-testing/tiny-random-XLMModel is still above, is it intended?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes hf-internal-testing/tiny-random-XLMForQuestionAnsweringSimple is only use for the QA tests, I think it make sense to keep hf-internal-testing/tiny-random-XLMModel for other tasks and tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I misread, I see.

"xlm_roberta": "hf-internal-testing/tiny-xlm-roberta",
"yolos": "hf-internal-testing/tiny-random-YolosModel",
}
Expand Down
Loading