Modify model id for test #1628
Merged
Modify model id for test #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxmarty
reviewed
Jan 9, 2024
| @@ -149,6 +149,7 @@ | |||
| "wav2vec2-conformer": "hf-internal-testing/tiny-random-wav2vec2-conformer", | |||
| "wavlm": "hf-internal-testing/tiny-random-WavlmModel", | |||
| "xlm": "hf-internal-testing/tiny-random-XLMModel", | |||
| "xlm_qa": "hf-internal-testing/tiny-random-XLMForQuestionAnsweringSimple", # issue with default hf-internal-testing in transformers QA pipeline post-processing | |||
There was a problem hiding this comment.
Thank you, hf-internal-testing/tiny-random-XLMModel is still above, is it intended?
There was a problem hiding this comment.
Yes hf-internal-testing/tiny-random-XLMForQuestionAnsweringSimple is only use for the QA tests, I think it make sense to keep hf-internal-testing/tiny-random-XLMModel for other tasks and tests
fxmarty
approved these changes
Jan 9, 2024
echarlaix
added a commit
that referenced
this pull request
Jan 19, 2024
* Modify model id for test * add comment * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA pipeline post-processing is failing for models like https://huggingface.co/hf-internal-testing/tiny-random-XLMModel or https://huggingface.co/hf-internal-testing/tiny-random-xlm as described in huggingface/transformers#28000