Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct BLOCK_SIZE in matmul function for ggml type #668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xffxff
Copy link

@xffxff xffxff commented Aug 30, 2023

To compute k_in_lhs_blocks, we should use T::VecDottype::BLOCK_SIZE because we obtain lhs_b using T::VecDotType::from_float. Similarly, to calculate k_in_rhs_blocks, we need to use T::BLOCK_SIZE since rhs_t is a slice of T (I'm just starting to learn quantization, so I'm not sure if it's correct, but it seems intuitive to me)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant