fix: use correct BLOCK_SIZE in matmul function for ggml type #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compute
k_in_lhs_blocks
, we should useT::VecDottype::BLOCK_SIZE
because we obtainlhs_b
usingT::VecDotType::from_float
. Similarly, to calculatek_in_rhs_blocks
, we need to useT::BLOCK_SIZE
sincerhs_t
is a slice ofT
(I'm just starting to learn quantization, so I'm not sure if it's correct, but it seems intuitive to me)