Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/all-close #1549

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

FL33TW00D
Copy link
Contributor

No description provided.

@LaurentMazare
Copy link
Collaborator

What is your use case for this? I'm a bit reluctant to adding too much helper functions in the main crate, especially as methods, it makes the tensor objects harder to use as there are plenty of methods available, and also it adds some complexity that might be deferred to other crates.
(also typically we would name this all_close and not allclose, the behavior on nan would have to be documented and checked, there would be no need for testing it on anything else than cpu as it doesn't define device specific basic ops)

@FL33TW00D
Copy link
Contributor Author

@LaurentMazare I'm working on #1414 currently, and this would be handy to compare against known ground truths.

Will fix the remaining issues.

@LaurentMazare
Copy link
Collaborator

Ah great that you're looking at #1414, would certainly be good to iron out these whisper discrepancies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants