Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, Candle only has a fixed set of backends (CPU, CUDA and Metal). Some other frameworks like PyTorch or Burn supports custom backends.
This PR contains changes enabling to create and use custom backend.
This can be useful when user wants to use a different GPGPU framework (like OpenCL) or some specific hardware.
The PR consists of two parts:
BackendDevice
andBackendStorage
traits (removednew
method, made location an associated type, renamed some methods to avoid ambiguity and other minor changes) and implementing them also forDevice
andStorage
.CustomDevice
andCustomStorage
that encapsulate a customBackendDevice
andBackendStorage
implementation (which is relatively tricky because these traits contain associated types and generic methods, butTesnor
doesn't have generic parameters, so implementation should go through dynamic dispatch, but this isn't exposed to user) and making types used by these traits public.Has it a chance to be merged?
If it is undesirable to stabilize backend API, then custom backends may be enabled by feature with a note that it is unstable.