allow users to define a variable number of lines in font_config #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
font_config.json and formats text accordingly
huderlem
requested changes
Dec 23, 2023
pkmnsnfrn
force-pushed
the
variable_lines
branch
from
0a4ee78 to
5d2bde4
Compare
huderlem
reviewed
Dec 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 92.56% 92.74% +0.17%
==========================================
Files 7 7
Lines 2409 2467 +58
==========================================
+ Hits 2230 2288 +58
Misses 114 114
Partials 65 65 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Discussion
This allow users to define an arbitrary number of lines for their message boxes, and poryscript will format text accordingly.
numLines== 3numLines== 2