shuffle code around in preparation to add support for actually computing scores #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elray1
commented
Dec 23, 2024
| @@ -120,34 +120,26 @@ validate_config_targets <- function(webevals_config, task_groups, task_id_names) | |||
| } | |||
|
|
|||
| # check that metrics are valid for the available output types | |||
| output_types_for_target <- purrr::map( | |||
There was a problem hiding this comment.
moved computation of output_types_for_target and target_is_ordinal into their own functions in utils-hub_tasks_config.R. These functions are now called from within get_metric_name_to_output_type.
Slightly awkwardly, to support issuing informative errors, we also compute them below if we need to issue the error.
elray1
commented
Dec 23, 2024
| @@ -251,61 +243,6 @@ validate_config_task_id_text <- function(webevals_config, task_groups, task_id_n | |||
| } | |||
|
|
|||
|
|
|||
| #' Get a data frame with 1 row for each metric, matching the metric with the | |||
There was a problem hiding this comment.
get_metric_name_to_output_type and get_standard_metrics moved to utils-metrics.R. I'm going to need these functions in the code to compute scores, so it's better to have them in a utils file.
zkamvar
previously approved these changes
Dec 23, 2024
get_target_is_ordinal --> is_target_ordinal Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils-metrics.Rand add unit testsutils-hub_tasks_config.R