filter task groups on target rather than getting indexes with target #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkamvar
approved these changes
Dec 23, 2024
| filter_task_groups_to_target <- function(task_groups, target_id) { | ||
| # For each task group, subset the target_metadata to just the entry for the target_id | ||
| # If the target_id is not in the task group, the target_metadata will be empty | ||
| task_groups <- purrr::map( | ||
| task_groups, | ||
| function(task_group) { |
There was a problem hiding this comment.
This is a much better second iteration! I would even go so far as to say that you could move this anonymous function into a named function (maybe trim_to_target_id).
Comment on lines
+11
to
+13
| task_group$target_metadata <- purrr::keep(task_group$target_metadata, | ||
| ~ .x$target_id == target_id) | ||
| return(task_group) |
There was a problem hiding this comment.
instead of returning task groups with empty target metadata, it might be better to return an empty list() or NULL. This way, you can use task_groups[lengths(task_groups) > 0] to filter the output later instead of using another purrr command.
There was a problem hiding this comment.
Thanks for the suggestions! (I didn't know the lengths function before)
I'm going to merge this as is so that I can keep moving on other pieces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a piece of refactoring that we identified as a nice-to-have in the review of #5.