Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update forecast data vignette #43

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update forecast data vignette #43

merged 1 commit into from
Nov 22, 2024

Conversation

elray1
Copy link
Contributor

@elray1 elray1 commented Nov 22, 2024 •
edited
Loading

This PR fixes the second point in issue #40

@elray1 elray1 changed the base branch from main to update_forecast_data_docs November 22, 2024 15:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

🚀 Deployed on https://6740aad48aae8e0091f0b45f--hubexamples-pr-previews.netlify.app

Base automatically changed from update_forecast_data_docs to main November 22, 2024 15:58
@elray1 elray1 closed this Nov 22, 2024
@elray1 elray1 reopened this Nov 22, 2024
@zkamvar zkamvar self-requested a review November 22, 2024 16:06
zkamvar
zkamvar approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now, but it would be good to reveal a bit more about the mechanics of how the data are derived.

@elray1 elray1 merged commit a0a3868 into main Nov 22, 2024
14 of 16 checks passed
@elray1 elray1 deleted the update_forecast_data_vignette branch November 22, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkamvar zkamvar zkamvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elray1 @zkamvar