remove snapshots of hubExamples data for tests, instead directly using hubExamples data objects #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g hubExamples data objects
elray1
commented
Jan 3, 2025
| @@ -125,7 +125,7 @@ score_model_out <- function(model_out_tbl, oracle_output, metrics = NULL, | |||
| #' Get scoring metrics | |||
| #' | |||
| #' @param forecast A scoringutils `forecast` object (see | |||
| #' [scoringutils' general information on creating a `forecast` object][scoringutils::as_forecast_doc_template()] | |||
| #' [scoringutils' general information on creating a forecast object][scoringutils::as_forecast_doc_template()] | |||
There was a problem hiding this comment.
This is unrelated to the main point of this PR, but fixes a complaint that check raised: score_model_out.R:127: @param markdown links must contain plain text.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 93.43% 99.35% +5.91%
==========================================
Files 5 5
Lines 198 154 -44
==========================================
- Hits 185 153 -32
+ Misses 13 1 -12 ☔ View full report in Codecov by Sentry. |
elray1
commented
Jan 3, 2025
| model_out_tbl <- hubex_forecast_outputs() | ||
| oracle_output <- hubex_forecast_oracle_output() | ||
| # Forecast data from hubExamples: <https://hubverse-org.github.io/hubExamples/reference/forecast_data.html> | ||
| forecast_outputs <- hubExamples::forecast_outputs |
There was a problem hiding this comment.
changed names from model_out_tbl --> forecast_outputs and oracle_output --> forecast_oracle_output for consistency with other tests using these data objects from hubExamples.
zkamvar
approved these changes
Jan 3, 2025
| @@ -125,7 +125,7 @@ score_model_out <- function(model_out_tbl, oracle_output, metrics = NULL, | |||
| #' Get scoring metrics | |||
| #' | |||
| #' @param forecast A scoringutils `forecast` object (see | |||
| #' [scoringutils' general information on creating a `forecast` object][scoringutils::as_forecast_doc_template()] | |||
| #' [scoringutils' general information on creating a forecast object][scoringutils::as_forecast_doc_template()] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #67