Refactor validation tests #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia transform functions
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
elray1
commented
Aug 20, 2024
Merged
zkamvar
requested changes
Aug 22, 2024
There was a problem hiding this comment.
This looks good. I made my notes below and a couple of broad observations:
- I would turn the warning into an error. Warnings are a weird sort of alert in R. Messages inform the user of processes that are going on and Errors tell the user that something is wrong. Warnings are a way of telling the user that something is weird and maybe wrong, but it shows up after the damage has been done.
- It's not a bad idea to test for the same error/warning in multiple places
- just a small note for testing errors: if it comes from another package, we may run into issues in the future if error messages change.
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
zkamvar
reviewed
Aug 22, 2024
zkamvar
approved these changes
Aug 22, 2024
|
Thanks for the constructive review! I'll merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #41, we refactored some validations that were duplicated in
transform_point_model_outandtransform_quantile_model_outinto a new/separate function,validate_model_out_target_obsthat is called from each of those transform functions.The main purpose of this PR is to tidy up the unit tests in an analogous way, so that tests of the transform functions that were really about those validation checks how just test the validation function instead. This reduces some duplication in tests.
Along the way I found a couple of errors in test setup which I have also fixed, and also added another check to
validate_model_out_target_obs.