Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor validations, rename target_data to target_observations #41

Merged
merged 3 commits into from
Aug 16, 2024
Merged

refactor validations, rename target_data to target_observations #41

merged 3 commits into from
Aug 16, 2024

Conversation

elray1
Copy link
Contributor

@elray1 elray1 commented Aug 16, 2024 •
edited
Loading

Doing two things in this PR:

  1. Rename target_data to target_observations to match decision made about name for this elsewhere, see this discussion comment.
  2. Refactor validation logic that was in common to both point and quantile predictions

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

🚀 Deployed on https://66bfaa1aa07baf8fd4ff7998--hubevals-pr-previews.netlify.app

@zkamvar zkamvar requested review from zkamvar and lshandross and removed request for zkamvar August 16, 2024 19:49
lshandross
lshandross reviewed Aug 16, 2024
View reviewed changes
Copy link

@lshandross lshandross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but just wanted to note that the org name still hasn't been updated in this package yet (so changes need to be made to both READMEs, the pkgdown yaml file, and CONTRIBUTING file)

@elray1
Copy link
Contributor Author

elray1 commented Aug 16, 2024

Thanks, Li. I will file a separate issue to make those updates!

@elray1 elray1 merged commit 5fcaf32 into main Aug 16, 2024
8 checks passed
@elray1 elray1 deleted the refactor_validation branch August 16, 2024 20:27
@elray1 elray1 mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lshandross lshandross lshandross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elray1 @lshandross