-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update code to correspond to latest scoringutils version #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i spoke too soon! Can you increment the package version and add something to the NEWS.md?
How should I increment the package version? The current version is |
in our experience, we've had issues where minor code changes have caused hard-to-diagnose downstream issues later. Hence my requests. I think we should increment to And I re-looked at the guidelines and say that NEWS updates are maybe only necesary for user-facing changes. So maybe that change should be seen as not mandatory. |
Is |
Who would have thought that this would happen so soon :)
scoringutils
just got a new update which slightly changes the interface -as_forecast
is nowas_forecast_quantile
andas_forecast_point
. This PR updates the corresponding function to work with the most recentscoringutils
version.Apologies for the short notice - in the future I'll try to coordinate PRs to make sure there is no gap between the two packages.