Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code to correspond to latest scoringutils version #33

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

nikosbosse
Copy link
Collaborator

@nikosbosse nikosbosse commented Jul 18, 2024

Who would have thought that this would happen so soon :)

scoringutils just got a new update which slightly changes the interface - as_forecast is now as_forecast_quantile and as_forecast_point. This PR updates the corresponding function to work with the most recent scoringutils version.

Apologies for the short notice - in the future I'll try to coordinate PRs to make sure there is no gap between the two packages.

Copy link

github-actions bot commented Jul 18, 2024

Copy link
Contributor

@nickreich nickreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nickreich nickreich self-requested a review July 18, 2024 17:09
Copy link
Contributor

@nickreich nickreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i spoke too soon! Can you increment the package version and add something to the NEWS.md?

@nikosbosse
Copy link
Collaborator Author

nikosbosse commented Jul 19, 2024

How should I increment the package version? The current version is 0.0.0.9000 which is a dev version already. And the News.md file is empty - so I think it needs a more comprehensive presentation of the package functionality first, rather than a sentence describing what the current version updates.

@nickreich
Copy link
Contributor

in our experience, we've had issues where minor code changes have caused hard-to-diagnose downstream issues later. Hence my requests.

I think we should increment to 0.0.0.9001. But I see the point about it being a dev branch though. I just think we should enforce these small things.

And I re-looked at the guidelines and say that NEWS updates are maybe only necesary for user-facing changes. So maybe that change should be seen as not mandatory.

@nikosbosse
Copy link
Collaborator Author

Is hubEvals ever meant to be on CRAN? otherwise it might make more sense to have a separate dev branch and have main be the latest release?

@nikosbosse nikosbosse merged commit d0b309a into main Jul 19, 2024
8 checks passed
@nikosbosse nikosbosse deleted the update-scoringutils branch July 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants