implements [support mapping of tasks.json task_id values to ptc task_ids text entries #25] #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ids text entries #25]
zkamvar
approved these changes
Nov 7, 2024
| "task_id_text": { | ||
| "description": "optional mapping of predtimechart task id values to text. keys are task_ids and values are an object whose keys are ptc task_id `value`s and values are ptc task_id `text`s", | ||
| "type": "object", | ||
| # todo additional validation: keys are str and values are dict[str:str] |
There was a problem hiding this comment.
This is the blind leading the blind so YMMV, but if all objects are key value pairs and all keys are strings, then we can check that all values are strings.
I think we can use patternProperties to check for this.
Suggested change
| # todo additional validation: keys are str and values are dict[str:str] | |
| "patternProperties": { | |
| "^*$": {"type": "string"} | |
| } |
There was a problem hiding this comment.
Thanks for the idea. I changed my local copy and got a bunch of errors, but this stuff can be tricky. For now, let's leave my commits as-is and then I can work on it when I have time. Thanks again.
| def test_hub_config_complex_forecast_hub_no_disclaimer(): | ||
| hub_dir = Path('tests/hubs/example-complex-forecast-hub') | ||
| hub_config = HubConfig(hub_dir, Path('tests/configs/example-complex-no-disclaimer.yml')) | ||
| assert hub_config.disclaimer == None | ||
| assert hub_config.disclaimer is None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements [support mapping of tasks.json task_id values to ptc task_ids text entries #25]
ptc_schema.py'stask_id_textproperty could use additional validation ("keys are str and values are dict[str:str]").