Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "disclaimer" from code and files, fix failing test #23

Closed
wants to merge 1 commit into from

Conversation

matthewcornell
Copy link
Collaborator

closes [Update schema to comply with predtimechart 2.0.11 #22] by removing "disclaimer" from code and files. updates demo/index.html to predtimechart 2.0.11 . fixes default value for reference_date_from_today(), which was causing failed tests

…oving "disclaimer" from code and files. updates demo/index.html to predtimechart 2.0.11 . fixes default value for `reference_date_from_today()`, which was causing failed tests
Copy link
Member

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the PR! I would request to make the disclaimer optional instead of removing it all together. I do think the disclaimer is a useful feature.

I've outlined the changes in #22 and I have a branch that I can push for a PR (I was working on it earlier when I was searching for the bug) if you would be okay reviewing that one.

@matthewcornell
Copy link
Collaborator Author

Thank you for making the PR! I would request to make the disclaimer optional instead of removing it all together. I do think the disclaimer is a useful feature.

I've outlined the changes in #22 and I have a branch that I can push for a PR (I was working on it earlier when I was searching for the bug) if you would be okay reviewing that one.

Sorry - I missed that. I'm moving too fast today - election jitters maybe. I thought we'd changed our minds about it being optional. Let's coordinate before I make any more changes, OK? I'm fine dropping this branch - only the failing test is important to keep.

@zkamvar
Copy link
Member

zkamvar commented Nov 4, 2024

Sorry - I missed that. I'm moving too fast today - election jitters maybe.

No worries! That is completely understandable. I'm fairly sure that I could have formatted that issue better (e.g. using a diff instead of just displaying the areas of the code).

I thought we'd changed our minds about it being optional.

The change was to allow it to be optional (based on @elray1's suggestion). In its current form, disclaimer is required whether or not a hub has anything to disclaim.

Let's coordinate before I make any more changes, OK? I'm fine dropping this branch - only the failing test is important to keep.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants