fix: use ddefu

huang-julien · Jan 23, 2025 · 2c92e7a · 2c92e7a
1 parent 148b35f
commit 2c92e7a
Showing 1 changed file with 25 additions and 22 deletions.
diff --git a/src/module.ts b/src/module.ts
@@ -7,48 +7,49 @@ import { getPresetFile, isPresetEntry } from './presets'
 import { normalize } from "pathe"
 import type { Nuxt } from "@nuxt/schema"
 import { fileURLToPath } from 'node:url'
+import defu from 'defu'
 
 async function module(nitro: Nitro) {
     nitro.options.alias['#nitro-opentelemetry/init'] = await getPresetFile(nitro)
 
-    if(isPresetEntry(nitro)) {
+    if (isPresetEntry(nitro)) {
         nitro.options.alias['#nitro-entry-file'] = nitro.options.entry
         nitro.options.entry = await getPresetFile(nitro)
     }
 
     nitro.hooks.hook('rollup:before', (nitro, rollupConfig) => {
         if (!rollupConfig.plugins) rollupConfig.plugins = [];
         const plugins = rollupConfig.plugins
-        if(Array.isArray(plugins)) {
+        if (Array.isArray(plugins)) {
             rollupConfig.plugins = plugins.filter((plugin) => {
-                if( plugin && 'name' in plugin) {
+                if (plugin && 'name' in plugin) {
                     // workaround for while waiting for configurable impound settings in nuxt
-                    return plugin.name!== 'impound'
+                    return plugin.name !== 'impound'
                 }
                 return true
             });
         }
 
-         (rollupConfig.plugins as Plugin[]).push({
+        (rollupConfig.plugins as Plugin[]).push({
             name: 'inject-init-plugin',
             async transform(code, id) {
-                const normalizedId = normalize(id)  
-                 // transform nitro entry file but there's probably a better way
-                if (normalizedId.includes('runtime/entries') || this.getModuleInfo(id)?.isEntry ) { 
+                const normalizedId = normalize(id)
+                // transform nitro entry file but there's probably a better way
+                if (normalizedId.includes('runtime/entries') || this.getModuleInfo(id)?.isEntry) {
                     const s = new MagicString(code)
                     s.prepend(`import '#nitro-opentelemetry/init';`)
-                 
+
                     return {
                         code: s.toString(),
                         map: s.generateMap({ hires: true }),
                         moduleSideEffects: true
                     }
-                } 
+                }
                 //  @todo find another way to mark it as side effect :/
                 if (normalizedId === nitro.options.alias['#nitro-opentelemetry/init']) {
                     const s = new MagicString(code)
                     return {
-                        moduleSideEffects: true, 
+                        moduleSideEffects: true,
                         code: s.toString(),
                         map: s.generateMap({ hires: true }),
                     }
@@ -66,16 +67,18 @@ async function module(nitro: Nitro) {
     if (nitro.options.renderer) {
         nitro.options.alias['#nitro-renderer'] = nitro.options.renderer
         nitro.options.renderer = fileURLToPath(new URL('runtime/renderer/renderer', import.meta.url))
-        nitro.options.externals.inline ||= []
-        nitro.options.externals.inline.push(nitro.options.renderer)
+        nitro.options.externals = defu(nitro.options.externals, {
+            inline: [nitro.options.renderer]
+        })
     }
 
     if (nitro.options.errorHandler) {
         nitro.options.alias['#nitro-error-handler'] = nitro.options.errorHandler
         nitro.options.errorHandler = fileURLToPath(new URL('runtime/renderer/error', import.meta.url))
-        nitro.options.externals.inline ||= []
-        nitro.options.externals.inline.push(nitro.options.errorHandler)
-    } 
+        nitro.options.externals = defu(nitro.options.externals, {
+            inline: [nitro.options.errorHandler]
+        })
+    }
 
     nitro.options.plugins.push(await resolvePath('nitro-opentelemetry/runtime/plugin', {
         extensions: ['.mjs', '.ts']
@@ -85,11 +88,11 @@ async function module(nitro: Nitro) {
 // Dual compatibility with Nuxt and Nitro Modules
 export default function moduleWithCompat(arg1: unknown, arg2: unknown) {
     if ((arg2 as Nuxt)?.options?.nitro) {
-      (arg2 as Nuxt).hooks.hookOnce("nitro:config", (nitroConfig) => {
-        nitroConfig.modules = nitroConfig.modules || [];
-        nitroConfig.modules.push(module);
-      });
+        (arg2 as Nuxt).hooks.hookOnce("nitro:config", (nitroConfig) => {
+            nitroConfig.modules = nitroConfig.modules || [];
+            nitroConfig.modules.push(module);
+        });
     } else {
-      module(arg1 as Nitro);
+        module(arg1 as Nitro);
     }
-  }
+}