Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile support #4

Open
hrushikeshrv opened this issue Sep 28, 2021 · 6 comments
Open

Add mobile support #4

hrushikeshrv opened this issue Sep 28, 2021 · 6 comments
Assignees
Labels
hacktoberfest Counts towards Hacktoberfest help wanted Extra attention is needed

Comments

@hrushikeshrv
Copy link
Owner

Currently, the editor uses the keyboard's arrow keys to navigate between different blocks in the equation. This is clearly not possible on mobile. We need to add navigation buttons that would perform the same function as when an arrow key is pressed. This will require editing the editor HTML to add the buttons, and also updating the constructor for MJXGUI to add event listeners to the added buttons to simulate a keypress event when the corresponding buttons are clicked.

Also, we need to open the keyboard when we are on mobile so users can type English characters.

@hrushikeshrv hrushikeshrv added hacktoberfest Counts towards Hacktoberfest help wanted Extra attention is needed labels Sep 28, 2021
@AvaterClasher
Copy link
Contributor

Hello i would like take to this on but i dont have much experience in vanilla js as i mainly work in react. But i think i can pull this off with your guidance.
Thank You

@hrushikeshrv
Copy link
Owner Author

Hi @AvaterClasher, thanks for your interest! I can guide you, however, this feature will need some experience working with vanilla js. Are you familiar with working with DOM events and adding and removing elements from the DOM in vanilla js?

@AvaterClasher
Copy link
Contributor

Yeah i know about it.

@hrushikeshrv
Copy link
Owner Author

Then I think you can work on it. I'll assign this issue to you. Let me know if you have any specific questions on how to get started!

@EntropyKN
Copy link

Hello, I'm testing on Android chrome, it seems to be impossible to open the keyboard when on mobile. Is this feature going to be implemented? thanks

@hrushikeshrv
Copy link
Owner Author

Hi @EntropyKN.
Yes, I am starting to implementing this feature. I can't give you a timeline for certain, but it should be ready soon. I still have to work out the approach I want to take. If you have any suggestions or if you would like to open a PR, that would be welcome too 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Counts towards Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants