Skip to content

Commit

Permalink
add theming to mediaccc
Browse files Browse the repository at this point in the history
  • Loading branch information
theScrabi committed Jan 29, 2019
1 parent 1ae54f6 commit e88a90f
Show file tree
Hide file tree
Showing 8 changed files with 114 additions and 12 deletions.
6 changes: 4 additions & 2 deletions app/src/main/java/org/schabi/newpipe/util/ServiceHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ public static int getIcon(int serviceId) {
case 0:
return R.drawable.place_holder_youtube;
case 1:
return R.drawable.place_holder_circle;
return R.drawable.place_holder_cloud;
case 2:
return R.drawable.place_holder_gadse;
default:
return R.drawable.service;
return R.drawable.place_holder_circle;
}
}

Expand Down
4 changes: 3 additions & 1 deletion app/src/main/java/org/schabi/newpipe/util/ThemeHelper.java
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ public static int getThemeForService(Context context, int serviceId) {
else if (selectedTheme.equals(darkTheme)) themeName = "DarkTheme";

themeName += "." + service.getServiceInfo().getName();
int resourceId = context.getResources().getIdentifier(themeName, "style", context.getPackageName());
int resourceId = context
.getResources()
.getIdentifier(themeName, "style", context.getPackageName());

if (resourceId > 0) {
return resourceId;
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 18 additions & 0 deletions app/src/main/res/values-v21/styles_services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,22 @@
<item name="colorAccent">@color/dark_soundcloud_accent_color</item>
</style>

<!-- Media.ccc -->
<style name="LightTheme.MediaCCC" parent="LightTheme.Switchable">
<item name="colorPrimary">@color/light_media_ccc_primary_color</item>
<item name="colorPrimaryDark">@color/light_media_ccc_statusbar_color</item>
<item name="colorAccent">@color/light_media_ccc_accent_color</item>
</style>

<style name="DarkTheme.MediaCCC" parent="DarkTheme.Switchable">
<item name="colorPrimary">@color/dark_media_ccc_primary_color</item>
<item name="colorPrimaryDark">@color/dark_media_ccc_statusbar_color</item>
<item name="colorAccent">@color/dark_media_ccc_accent_color</item>
</style>

<style name="BlackTheme.MediaCCC" parent="BlackTheme.Switchable">
<item name="colorPrimary">@color/dark_media_ccc_primary_color</item>
<item name="colorPrimaryDark">@color/dark_media_ccc_statusbar_color</item>
<item name="colorAccent">@color/dark_media_ccc_accent_color</item>
</style>
</resources>
18 changes: 9 additions & 9 deletions app/src/main/res/values/colors_services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@
<color name="dark_soundcloud_accent_color">#FFFFFF</color>
<color name="dark_soundcloud_statusbar_color">#ff9100</color>

<!-- MediaCCC -->
<color name="light_mediaccc_primary_color">#888888</color>
<color name="light_mediaccc_dark_color">#555555</color>
<color name="light_mediaccc_accent_color">#000000</color>
<color name="light_mediaccc_statusbar_color">#777777</color>
<!-- Media.CCC -->
<color name="light_media_ccc_primary_color">#9e9e9e</color>
<color name="light_media_ccc_dark_color">#616161</color>
<color name="light_media_ccc_accent_color">#000000</color>
<color name="light_media_ccc_statusbar_color">#afafaf</color>

<color name="dark_mediaccc_primary_color">#888888</color>
<color name="dark_mediaccc_dark_color">#555555</color>
<color name="dark_mediaccc_accent_color">#FFFFFF</color>
<color name="dark_mediaccc_statusbar_color">#777777</color>
<color name="dark_media_ccc_primary_color">#9e9e9e</color>
<color name="dark_media_ccc_dark_color">#616161</color>
<color name="dark_media_ccc_accent_color">#FFFFFF</color>
<color name="dark_media_ccc_statusbar_color">#afafaf</color>

</resources>
20 changes: 20 additions & 0 deletions app/src/main/res/values/styles_services.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

<style name="BlackTheme.YouTube" parent="BlackTheme.Switchable">
</style>

<!-- SoundCloud -->
<style name="LightTheme.SoundCloud" parent="LightTheme.Switchable">
<item name="colorPrimary">@color/light_soundcloud_primary_color</item>
Expand All @@ -28,4 +29,23 @@
<item name="colorAccent">@color/dark_soundcloud_accent_color</item>
</style>

<!-- Media.ccc -->
<style name="LightTheme.MediaCCC" parent="LightTheme.Switchable">
<item name="colorPrimary">@color/light_media_ccc_primary_color</item>
<item name="colorPrimaryDark">@color/light_media_ccc_statusbar_color</item>
<item name="colorAccent">@color/light_media_ccc_accent_color</item>
</style>

<style name="DarkTheme.MediaCCC" parent="DarkTheme.Switchable">
<item name="colorPrimary">@color/dark_media_ccc_primary_color</item>
<item name="colorPrimaryDark">@color/dark_media_ccc_statusbar_color</item>
<item name="colorAccent">@color/dark_media_ccc_accent_color</item>
</style>

<style name="BlackTheme.MediaCCC" parent="BlackTheme.Switchable">
<item name="colorPrimary">@color/dark_media_ccc_primary_color</item>
<item name="colorPrimaryDark">@color/dark_media_ccc_statusbar_color</item>
<item name="colorAccent">@color/dark_media_ccc_accent_color</item>
</style>

</resources>
60 changes: 60 additions & 0 deletions assets/media_gadse.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit e88a90f

Please sign in to comment.