Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Reader #140

Merged
merged 12 commits into from
Feb 12, 2025
Merged

Core Reader #140

merged 12 commits into from
Feb 12, 2025

Conversation

movsesyanae
Copy link
Collaborator

No description provided.

Copy link

@zoreoo zoreoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Did you test if the new way of matching events or matching caller-callees is faster than having them in separate functions? If so, maybe we could delete those functions?

@lithomas1 lithomas1 closed this Feb 12, 2025
@lithomas1 lithomas1 reopened this Feb 12, 2025
Copy link
Collaborator

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

I'll land this after the fix CI PR.
(shouldn't be any harm here as the change doesn't affect anything right now).

@lithomas1 lithomas1 merged commit c8e754a into develop Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants