Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-676 Migrate Jirabot Improvements #784

Merged
merged 1 commit into from
Jan 9, 2025
Merged

HPCC4J-676 Migrate Jirabot Improvements #784

merged 1 commit into from
Jan 9, 2025

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Jan 7, 2025 •
edited
Loading

  • Updated out of date actions
  • Moved to using more secure ENV variables to echo Github variables
  • Fixed project prefix comparison

Signed-off-by: James McMullan James.McMullan@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu
HPCC4J-676 Migrate Jirabot Improvements
ef20af9 
- Updated out of date actions
- Moved to using more secure ENV variables to echo Github variables
- Fixed project prefix comparison

Signed-off-by: James McMullan James.McMullan@lexisnexis.com
@jpmcmu jpmcmu changed the title HPCC4J-676 Migrate Jirabot Improvements WIP: HPCC4J-676 Migrate Jirabot Improvements Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-676

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@jpmcmu jpmcmu changed the base branch from master to candidate-9.2.x January 7, 2025 19:17
@jpmcmu jpmcmu requested a review from rpastrana January 7, 2025 19:17
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jan 7, 2025

@rpastrana please review

@jpmcmu jpmcmu changed the title WIP: HPCC4J-676 Migrate Jirabot Improvements HPCC4J-676 Migrate Jirabot Improvements Jan 7, 2025
@rpastrana rpastrana merged commit d6a3975 into hpcc-systems:candidate-9.2.x Jan 9, 2025
5 of 7 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Jirabot Action Result:
Added fix version: 9.2.148
Added fix version: 9.4.122
Added fix version: 9.6.74
Added fix version: 9.8.48
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana