Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-614 WsStore IPT invalid character tests #717

Closed
wants to merge 1 commit into from
Closed

HPCC4J-614 WsStore IPT invalid character tests #717

wants to merge 1 commit into from

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Jun 15, 2024 •
edited
Loading

  • Adds new WsStore tests based on values which include IPT attribute delimiters
  • Fixes issue noticed in wsstoreclient

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@rpastrana rpastrana requested a review from jpmcmu June 15, 2024 01:35
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-614

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@rpastrana rpastrana mentioned this pull request Jun 17, 2024
Merged
39 tasks
@rpastrana rpastrana force-pushed the HPCC4J-614-InvalidIPTTests branch from a0f72f7 to 60cff93 Compare June 28, 2024 17:53
jpmcmu
jpmcmu approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good to me, only question I have is related to characters in the username. I vaguely remember that you had said that special characters in the username might cause problems, do we need a test case for that as well?

@rpastrana
Copy link
Member Author

@rpastrana looks good to me, only question I have is related to characters in the username. I vaguely remember that you had said that special characters in the username might cause problems, do we need a test case for that as well?

Yes, thanks for reminding me. The challenge is changing the user name only for this test...

@rpastrana
Copy link
Member Author

This PR is dependent on HPCC-Platform changes: hpcc-systems/HPCC-Platform#18763

@rpastrana rpastrana requested a review from jpmcmu July 10, 2024 16:53
@rpastrana
Copy link
Member Author

@jpmcmu please review the latest commit

jpmcmu
jpmcmu approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jpmcmu jpmcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks good

@rpastrana
HPCC4J-614 WsStore IPT invalid character tests
e40c5af 
- Adds new WsStore tests based on values which include IPT attribute delimiters
- Fixes issue noticed in wsstoreclient
- Adds ability to test encod-able username
- Adds fetch encoded key test
- Adds fetch invalid key test

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
@rpastrana rpastrana force-pushed the HPCC4J-614-InvalidIPTTests branch from 758587c to e40c5af Compare July 12, 2024 17:30
@rpastrana
Copy link
Member Author

Cannot merge before this: hpcc-systems/HPCC-Platform#18763

@rpastrana rpastrana changed the base branch from candidate-9.6.x to candidate-9.4.x July 19, 2024 14:01
@rpastrana rpastrana changed the base branch from candidate-9.4.x to candidate-9.6.x July 22, 2024 14:13
@rpastrana rpastrana mentioned this pull request Jul 22, 2024
Merged
22 tasks
@rpastrana
Copy link
Member Author

closing in favor of #725

@rpastrana rpastrana closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcmu jpmcmu jpmcmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @jpmcmu