feat: Add dgrid #4280
Merged
feat: Add dgrid #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeclrsg
reviewed
Nov 4, 2024
There was a problem hiding this comment.
@GordonSmith noticed a handful of minor things. Also, GH Actions made a comment about a test in dgrid.browser.spec.ts. I didn't follow why it had a problem with that specific test, I saw one in there where it was expecting false to be true.
.vitepress_v2/config.ts
Outdated
| // File might not exit yet --- | ||
| } | ||
|
|
||
| apiPackage?.members.forEach(entyrPoint => { |
There was a problem hiding this comment.
typo here, entyrPoint instead of entryPoint
| @@ -8,6 +8,7 @@ const menuList = ["List item 1", "This is Item 2", "List item 3", "This is list | |||
|
|
|||
| describe("Widget.classed", () => { | |||
| it("set/get", function () { | |||
| debugger; | |||
There was a problem hiding this comment.
debugger statement left in here?
packages/dgrid/src/index.ts
Outdated
|
|
||
| // Must be last... | ||
| export { Deferred, domConstruct, Memory, QueryResults } from "@hpcc-js/dgrid-shim"; | ||
| // export { Deferred, domConstruct, Memory, QueryResults } from "./dgrid-shim.ts"; |
There was a problem hiding this comment.
should this be uncommented?
packages/dgrid/tmp.txt
Outdated
| @@ -0,0 +1,106 @@ | |||
|
|
|||
There was a problem hiding this comment.
was this file supposed to be included in the commit?
| @@ -8,6 +8,7 @@ export function removeStrict(): Plugin { | |||
| build.initialOptions.write = false; | |||
| build.onEnd((result) => { | |||
| result?.outputFiles?.forEach(file => { | |||
| console.log(file.path); | |||
There was a problem hiding this comment.
console.log left here? or is it supposed to be, and should it have some prefix about what's happening?
GordonSmith
force-pushed
the
V3_MORE_MIGRATIONS
branch
from
518ec57 to
02083c8
Compare
Consolidate simple index.html testing Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
V3_MORE_MIGRATIONS
branch
from
02083c8 to
da14281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consoldiate simple index.html testing
Checklist:
Testing: