Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "option" get/set to Editor #4147

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

GordonSmith
Copy link
Member

Deprecated setOption as it has issues when used prior to the underlying _codemirror creation

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Deprecated setOption as it has issues when used prior to the underlying `_codemirror` creation

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith requested a review from jeclrsg December 21, 2023 12:07
@GordonSmith GordonSmith merged commit 3073cec into hpcc-systems:trunk Jan 2, 2024
5 checks passed
@GordonSmith GordonSmith deleted the EDITOR_OPTION branch July 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants