Merge pull request #4326 from GordonSmith/EXTRA_FETCH_ERRORHANDLING_3

feat: Allow fetch exceptions to propogate up the stack
hpcc-systems · Jan 21, 2025 · 348b5e0 · 348b5e0
2 parents ed4453e + 1ce39f6
commit 348b5e0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/packages/comms/src/espConnection.ts b/packages/comms/src/espConnection.ts
@@ -138,14 +138,6 @@ export class ESPConnection implements IConnection {
                 return retVal;
             }
             return response;
-        }).catch(e => {
-            if (e.isESPExceptions) {
-                throw e;
-            }
-            throw new ESPExceptions(action, request, {
-                Source: "ESPConnection.send",
-                Exception: [{ Code: 0, Message: e.message }]
-            });
         });
     }
 

diff --git a/packages/comms/src/services/wsWorkunits.ts b/packages/comms/src/services/wsWorkunits.ts
@@ -68,10 +68,8 @@ export class WorkunitsService extends WorkunitsServiceBase {
     }
 
     Ping(): Promise<WsWorkunits.WsWorkunitsPingResponse> {
-        return this._connection.send("Ping", {}, "json", false, undefined, "WsWorkunitsPingResponse").then((response) => {
+        return this._connection.send("Ping", {}, "json", false, undefined, "WsWorkunitsPingResponse").then(() => {
             return { result: true };
-        }).catch((e: Error) => {
-            return { result: false, error: e };
         });
     }