Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33199 Workunits not handling ESP Exceptions #19404

Merged
merged 1 commit into from
Jan 14, 2025
Merged

HPCC-33199 Workunits not handling ESP Exceptions #19404

merged 1 commit into from
Jan 14, 2025

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 13, 2025 •
edited
Loading

Catch exception and allow list to clear.
Fixed an issue where WUQuery would be called twice after a filter change. Fixed an issue where sorting a column back to default didn't remove the previous sort condition

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 13, 2025 13:47
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33199

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

GordonSmith
GordonSmith commented Jan 13, 2025
View reviewed changes
esp/src/src-react/components/controls/Grid.tsx Outdated
@@ -17,6 +17,7 @@ import { useUserTheme } from "../../hooks/theme";
* useWhatChanged([count, selectionHandler, sorted, start, store, query], "count, selectionHandler, sorted, start, store, query");
*
*/
import { useWhatChanged } from "@simbathesailor/use-what-changed";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

GordonSmith
GordonSmith commented Jan 13, 2025
View reviewed changes
esp/src/src-react/components/controls/Grid.tsx Outdated

useWhatChanged([abortController?.current?.signal, count, selectionHandler, start, store, query, sorted], "signal, count, selectionHandler, start, store, query, sorted");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@GordonSmith
HPCC-33199 Workunits not handling ESP Exceptions
fe5ee84 
Catch exception and allow list to clear.
Fixed an issue where WUQuery would be called twice after a filter change.
Fixed an issue where sorting a column back to default didn't remove the previous sort condition

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith force-pushed the HPCC-33199-WUQUERY_EXCEPTION branch from bbffd53 to fe5ee84 Compare January 13, 2025 13:49
@ghalliday ghalliday merged commit e690053 into hpcc-systems:candidate-9.2.x Jan 14, 2025
50 of 51 checks passed
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.2.150
Added fix version: 9.4.122
Added fix version: 9.6.76
Added fix version: 9.8.48
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GordonSmith @jeclrsg @ghalliday