HPCC-33167 Add unique ID to each metric

[kenrowland]

Added unique ID to each metric when constructed

Signed-Off-By: Kenneth Rowland kenneth.rowland@lexisnexisrisk.com

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33167

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

[rpastrana]

@kenrowland the change seems fine, but it's not clear what practical advantage is gained.
Also, are the ids simple sequential ints across the entire HPCC cluster, or is this per process?

[kenrowland]

@rpastrana The Jira covers an intended use. The unique ID is per process. Technically per loaded jlib.

[rpastrana]

@rpastrana The Jira covers an intended use. The unique ID is per process. Technically per loaded jlib.

Thanks for that @kenrowland, I asked because nothing seems to be consuming the id. So the intended use per the jira is to "avoid the repeated reconstruction of the fully qualified metric names" but this change only adds the unique ID, and there's no linked jira to make use of the unique ID. I understand you're making a concerted effort to keep your PRs at manageable size, but I'd consider either including the uid consumer logic here (it would be within scope of jira) or create the corresponding jira and linking it. If the consumer of the uid is expected to be outside of hpcc, please update the jira description as well.

[rpastrana]

per offline convo, consider changing the id member to unsigned, and add link to jira proposed to utilize this feature

[kenrowland]

HPCC-33204 added to make use of this change.

[rpastrana]

@kenrowland seems fine

[kenrowland]

@ghalliday Please merge

[ghalliday]

I am also not sure of the benefit of this change, but I will merge it.

[github-actions]

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'